Skip to content

feat(debug): removed allow-list filtering for headers when printing r… #1628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cgoetz-inovex merged 6 commits into from
Oct 2, 2026
Merged

feat(debug): removed allow-list filtering for headers when printing r… #1628

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5c4aba5
feat(debug): removed allow-list filtering for headers when printing r…
cgoetz-inovex Sep 24, 2026
e04ebbf
Merge branch 'main' into feat/STACKITCLI-456-debug-resp-header-print
cgoetz-inovex Sep 24, 2026
6235c89
fix/squash
cgoetz-inovex Sep 24, 2026
fddf5d2
add test
cgoetz-inovex Sep 28, 2026
da8ebda
fix linter, squash
cgoetz-inovex Oct 2, 2026
51bafb5
Merge branch 'main' into feat/STACKITCLI-456-debug-resp-header-print
cgoetz-inovex Oct 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add test
  • Loading branch information
@cgoetz-inovex
cgoetz-inovex committed Sep 28, 2026
commit fddf5d22a833a031e1fd9bb3dada681e4779db87
12 changes: 12 additions & 0 deletions internal/pkg/print/debug_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -496,6 +496,18 @@
},
isValid: true,
},
{
description: "more headers",
inputResp: fixtureHTTPResponse(func(resp *http.Response) {

Check failure on line 501 in internal/pkg/print/debug_test.go

View workflow job for this annotation

GitHub Actions / CI 

response body must be closed (bodyclose)
resp.Header.Add("X-Trace-Id", "trace-id")
}),
expected: []string{
"response from http://example.com: HTTP/1.1 200 OK",
"response headers: [Accept: application/json, Content-Length: 15, Content-Type: application/json, X-Trace-Id: trace-id]",
"response body: [key: value]",
},
isValid: true,
},
{
description: "empty body",
inputResp: fixtureHTTPResponse(func(resp *http.Response) { // nolint:bodyclose // false positive, body is closed in the test
Expand Down
Loading