refactor(ufw):

- added update implementation
stackitcloud · alextiugan15 · Sep 2, 2026 · Sep 3, 2026 · Sep 3, 2026 · Sep 4, 2026
commit 8ab1d41eaf2c78f0bbe174111a03215c01dadcf3
@@ -1 +1,173 @@
 package update
+
+import (
+	"context"
+	"fmt"
+
+	"github.com/spf13/cobra"
+	"github.com/stackitcloud/stackit-cli/internal/pkg/args"
+	"github.com/stackitcloud/stackit-cli/internal/pkg/errors"
+	"github.com/stackitcloud/stackit-cli/internal/pkg/examples"
+	"github.com/stackitcloud/stackit-cli/internal/pkg/flags"
+	"github.com/stackitcloud/stackit-cli/internal/pkg/globalflags"
+	"github.com/stackitcloud/stackit-cli/internal/pkg/projectname"
+	"github.com/stackitcloud/stackit-cli/internal/pkg/services/ufw/client"
+	"github.com/stackitcloud/stackit-cli/internal/pkg/spinner"
+	"github.com/stackitcloud/stackit-cli/internal/pkg/types"
+	"github.com/stackitcloud/stackit-cli/internal/pkg/utils"
+	ufw "github.com/stackitcloud/stackit-sdk-go/services/ufw/v1api"
+	"github.com/stackitcloud/stackit-sdk-go/services/ufw/v1api/wait"
+
+	"github.com/stackitcloud/stackit-cli/internal/pkg/print"
+)
+
+const (
+	instanceIdArg = "INSTANCE_ID"
+
+	sourceIpFlag    = "sourceIp"
+	directionFlag   = "direction"
+	descriptionFlag = "description"
+	etherTypeFlag   = "etherType"
+	portRangeFlag   = "portRange"
+	protocolFlag    = "protocol"
+)
+
+type inputModel struct {
+	*globalflags.GlobalFlagModel
+	RuleRefId string
+
+	SourceIp    *string
+	Direction   *string
+	Description *string
+	EtherType   *string
+	PortRange   *string
+	Protocol    *string
+}
+
+func NewCmd(params *types.CmdParams) *cobra.Command {
+	cmd := &cobra.Command{
+		Use:   fmt.Sprintf("update %s", instanceIdArg),
+		Short: "Updates an UFW rule instance",
+		Long:  "Updates a STACKIT Unified Firewall (UFW) rule instance.",
+		Args:  args.SingleArg(instanceIdArg, utils.ValidateUUID),
+		Example: examples.Build(
+			examples.NewExample(
+				`Update a UFW rule instance with "1.1.1.1/32" as sourceIp for instance with id=ID`,
+				"$ stackit ufw instance update ID --sourceIp 1.1.1.1/32"),
+		),
+		RunE: func(cmd *cobra.Command, args []string) error {
+			ctx := context.Background()
+			model, err := parseInput(params.Printer, cmd)
+			if err != nil {
+				return err
+			}
+
+			apiClient, err := client.ConfigureClient(params.Printer, params.CliVersion)
+			if err != nil {
+				return err
+			}
+
+			projectLabel, err := projectname.GetProjectName(ctx, params.Printer, params.CliVersion, cmd)
+			if err != nil {
+				params.Printer.Debug(print.ErrorLevel, "get project name: %v", err)
+				projectLabel = model.ProjectId
+			}
+
+			prompt := fmt.Sprintf("Are you sure you want to update a UFW rule instance for project %q?", projectLabel)
+			err = params.Printer.PromptForConfirmation(prompt)
+			if err != nil {
+				return err
+			}
+
+			req := buildRequest(ctx, model, apiClient)
+
+			resp, err := req.Execute()
+			if err != nil {
+				return fmt.Errorf("update UFW rule instance: %w", err)
+			}
+			instanceId := resp.RefId
+
+			if !model.Async {
+				err := spinner.Run(params.Printer, "Updating ufw rule instance", func() error {
+					_, err = wait.UpdateRuleWaitHandler(ctx, apiClient.DefaultAPI, model.ProjectId, model.Region, *instanceId).WaitWithContext(ctx)
+					return err
+				})
+				if err != nil {
+					return fmt.Errorf("wait for UFW rule instance updating process: %w", err)
+				}
+			}
+
+			return outputResult(params.Printer, model.OutputFormat, model.Async, projectLabel, resp)
+		},
+	}
+	configureFlags(cmd)
+	return cmd
+}
+
+func configureFlags(cmd *cobra.Command) {
+	cmd.Flags().StringP(sourceIpFlag, "s", "", "The IP (CIDR) to which the rule applies (e.g. 192.168.0.1/32)")
+	cmd.Flags().StringP(directionFlag, "d", "", "Direction (the direction of the traffic, typically ingress or egress, for security rules type)")
+	cmd.Flags().StringP(descriptionFlag, "D", "", "Description")
+	cmd.Flags().StringP(etherTypeFlag, "e", "", "Specifies the bound of the rule (for security rules type)")
+	cmd.Flags().StringP(portRangeFlag, "r", "", "Port range (the Port range to which the rule applies, for security rules type)")
+	cmd.Flags().StringP(protocolFlag, "o", "", "The network protocol (e.g. TCP, UDP, ICMP, for security rules type)")
+
+	err := flags.MarkFlagsRequired(cmd, sourceIpFlag)
+	cobra.CheckErr(err)
+}
+
+func parseInput(p *print.Printer, cmd *cobra.Command) (*inputModel, error) {
+	globalFlags := globalflags.Parse(p, cmd)
+	if globalFlags.ProjectId == "" {
+		return nil, &errors.ProjectIdError{}
+	}
+
+	if globalFlags.Region == "" {
+		return nil, &errors.RegionError{}
+	}
+
+	model := inputModel{
+		GlobalFlagModel: globalFlags,
+
+		SourceIp:    flags.FlagToStringPointer(p, cmd, sourceIpFlag),
+		Direction:   flags.FlagToStringPointer(p, cmd, directionFlag),
+		Description: flags.FlagToStringPointer(p, cmd, descriptionFlag),
+		EtherType:   flags.FlagToStringPointer(p, cmd, etherTypeFlag),
+		PortRange:   flags.FlagToStringPointer(p, cmd, portRangeFlag),
+		Protocol:    flags.FlagToStringPointer(p, cmd, protocolFlag),
+	}
+
+	p.DebugInputModel(model)
+	return &model, nil
+}
+
+func buildRequest(ctx context.Context, model *inputModel, apiClient *ufw.APIClient) ufw.ApiUpdateRuleRequest {
+	req := apiClient.DefaultAPI.UpdateRule(ctx, model.ProjectId, model.Region, model.RuleRefId)
+
+	// TODO - add logic for field checking: existing ACLs, correct product, type, instanceID maybe
+
+	req = req.UpdateRulePayload(ufw.UpdateRulePayload{
+		SourceIP:  *model.SourceIp,
+		Direction: model.Direction,
+		EtherType: model.EtherType,
+		PortRange: model.PortRange,
+		Protocol:  model.Protocol,
+	})
+
+	return req
+}
+
+func outputResult(p *print.Printer, outputFormat string, async bool, projectLabel string, rule *ufw.UpdateRuleResponse) error {
+	if rule == nil {
+		return fmt.Errorf("response is nil")
+	}
+
+	return p.OutputResult(outputFormat, rule, func() error {
+		operationState := "Updated"
+		if async {
+			operationState = "Triggered updating process of"
+		}
+		p.Outputf("%s rule for project %q. Rule refID: %s\n", operationState, projectLabel, utils.PtrString(rule.RefId))
+		return nil
+	})
+}
@@ -6,6 +6,7 @@ import (
 	"github.com/stackitcloud/stackit-cli/internal/cmd/ufw/rules/delete"
 	"github.com/stackitcloud/stackit-cli/internal/cmd/ufw/rules/describe"
 	"github.com/stackitcloud/stackit-cli/internal/cmd/ufw/rules/list"
+	"github.com/stackitcloud/stackit-cli/internal/cmd/ufw/rules/update"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/args"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/types"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/utils"
@@ -27,6 +28,6 @@ func addSubcommands(cmd *cobra.Command, params *types.CmdParams) {
 	cmd.AddCommand(list.NewCmd(params))
 	cmd.AddCommand(describe.NewCmd(params))
 	cmd.AddCommand(create.NewCmd(params))
-	//cmd.AddCommand(update.NewCmd(params))
+	cmd.AddCommand(update.NewCmd(params))
 	cmd.AddCommand(delete.NewCmd(params))
 }