Conversation
This commit includes a bunch of changes: - The Role and RoleGroup types are now versioned via our versioned macro. - It introduces two new versions: v1alpha1 and v1alpha2. v1alpha1 represents the shape of these types unchanged up until now. v1alpha2 introduces the changes which made versioning these types necessary at all. - In v1alpha2 the replicas field was changed from a simple Option<u16> to a complex enum to support our planned auto-scaling mechanism. This is a breaking change for primarily two reasons: - The shape of Role and RoleGroup changed in v1alpha2. - The location of the Role, RoleGroup, and supporting code (like function and helper types) changed. The code is now located at stackable_operator::crd::role.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caution
The CRD structure needs to be decided on. Also, this PR needs a changelog entry before it can be merged.
Proposed CRD shape
Summary of changes
Note
A whole bunch of changes are just code moves, no new code.
This PR includes a bunch of changes:
RoleandRoleGrouptypes are now versioned via our versioned macro.v1alpha1andv1alpha2.v1alpha1represents the shape of these types unchanged up until now.v1alpha2introduces the changes which made versioning these types necessary at all.v1alpha2the replicas field was changed from a simple Option to a complex enum to support our planned auto-scaling mechanism.This is a breaking change for primarily two reasons:
RoleGroupchanged in v1alpha2.RoleGroup, and supporting code (like function and helper types) changed. The code is now located atstackable_operator::crd::role.