Skip to content

Feat/s3 file browser v1 - #208

Open
dklOrdix wants to merge 200 commits into
mainfrom
feat/s3-file-browser-v1
Open

Feat/s3 file browser v1#208
dklOrdix wants to merge 200 commits into
mainfrom
feat/s3-file-browser-v1

Conversation

@dklOrdix

@dklOrdix dklOrdix commented Jun 18, 2026 •
edited by F3l1x1vo
Loading

Copy link
Copy Markdown
Collaborator

Closes #129

dklOrdix and others added 30 commits May 4, 2026 09:18
@dklOrdix
refactor(frontend): clean up and restructure app
161ce0e
@dklOrdix
fix: add lint:fix script to package.json and clean up trailing comma …
d2de208 
…in +layout.svelte
@dklOrdix
docs: update AGENTS.md to include Material UI icon library usage
c81b4d0
@dklOrdix
refactor(header): move components for header into own directory
9add069
@dklOrdix
chore: dedupe lockfile
8343022
@dklOrdix
fix(sidebar): add hover cursor style to toggle button
4bc8e93
@dklOrdix
chore(types): centralise navigation and auth types; update header/sid…
952dc80 
…ebar imports

Co-authored-by: Copilot <copilot@github.com>
@dklOrdix
feat(storage): initial Filebrowser UI implementation
cba7866 
Co-authored-by: Copilot <copilot@github.com>
@dklOrdix
refactor(storage): extract service layer and consolidate storage type…
5de8d9f 
…s/utils

Co-authored-by: Copilot <copilot@github.com>
@dklOrdix
Merge branch 'feat/s3-file-browser' into feat/s3-file-browser-ui
20909ae
@dklOrdix
chore(storage): remove outdated STORAGE_REORG_PLAN.md
2b33533
@dklOrdix
fix(lint): resolve errors
aeac85d
@dklOrdix
refactor(tests): update ThemeToggle tests to use checkbox role
f2ba284 
Co-authored-by: Copilot <copilot@github.com>
@dklOrdix
style: format code
af9b651
@dklOrdix
fix(tests): update theme toggle role from button to checkbox
8373974 
Co-authored-by: Copilot <copilot@github.com>
@dklOrdix
fix: revert changes to Theme Toggle
7aff59b
@dklOrdix
fix: revert changes to Theme Toggle
266a045
@dklOrdix
Merge pull request #90 from stackabletech/feat/s3-file-browser-ui
805f693 
feat(storage): initial Filebrowser UI implementation
@F3l1x1vo
#80 use pagination controls to navigate the file browser
3386182
@F3l1x1vo
#80 show page counter for pagination control
b77bcfa 
Co-authored-by: Copilot <copilot@github.com>
@F3l1x1vo
#80 fix lint and svelte check
48b552e 
Co-authored-by: Copilot <copilot@github.com>
@F3l1x1vo
fix lint error
7c9733f
@F3l1x1vo
Merge pull request #100 from stackabletech/feat/s3-file-browser-pagin…
9d85f57 
…ation

S3 File Browser Page Navigation (Pagination)
@F3l1x1vo
File Browser: Feature Flag (#105)
b4e25ec 
* #96 disable the storage browser if feature flag is set

* #96 fix svelte-check

* #96 fix lint

* #96 disable storage browser by default
@F3l1x1vo
Rename option STACKABLE_UI_COMPLETION_DISABLED (#106)
c36f1c8
@F3l1x1vo
S3 File Browser: Shared Pagination Component (#103)
ff43b22 
* #102 refactor pagination controls into a separate component

* #102 simplified pagination props
@dklOrdix
Merge branch 'main' into feat/s3-file-browser
ed9be69
@F3l1x1vo
#93 S3 File Browser: Document Preview (#113)
21bb0f2 
* #93 add modal preview for file display

* #93 fix broken e2e tests

* #93 add preview for parquet files, fix scrollbar visibility in preview, allow ms excel csv data for preview

* #93 improve parquet row fetch handling

* #93 fix lint

* #93 move preview endpoint logic into separate files

* #93 disable parquet preview
@dklOrdix
Feat/s3 file browser refactor object table (#120)
184fa84 
* refactor(ObjectTable): extract File and Folde rows into seperate components

* style: format code

* style: use camelCase

* style: use camelCase
@dklOrdix @F3l1x1vo
#91 - Feat/s3 filebrowser downloads (#116)
8886814 
* feat: implement single-file download functionality and error handling for S3 storage

* feat: refactor S3 download endpoint to use new API structure and improve error handling

* chore: remove obsolete note about static download route segment in tech debt documentation

* style: format code

* fix: improve type safety in S3 error handling

* fix: preview action

* feat: add context menu header and improve file selection handling in FileExplorer

* fix: reset selection state on context menu close and refine download action logic

* style: format files

* style: remove pointer events from Actions row on ContextMenu

* #91 fix lint

---------

Co-authored-by: F3l1x1vo <fli@ordix.de>
Bohreromir
Bohreromir requested changes Sep 22, 2026
View reviewed changes
Comment thread dev/modules/env.sh Outdated
Comment thread dev/modules/summary.sh Outdated
Comment thread dev/modules/postgresql.sh Outdated
Comment thread dev/modules/garage.sh Outdated
Comment thread src/lib/server/db.ts
@Bohreromir

Bohreromir commented Sep 22, 2026 •
edited by F3l1x1vo
Loading

Copy link
Copy Markdown
Contributor

Some things I noticed while testing the UI

Manage Connections

  • Host field accepts any value "%/()$=("?§/("

Bucketview

  • When trying to move a folder into the location where it already is located: Two contradicting toasts appear
image

The folder stayed where it was located while the folder contents got renamed(?)
Another time the folder was renamed too

  • When clearing history/failed operations box the folder nav changes size
  • When creating a new file paste (ctrl+p) does not work in the filename field
  • Fonts look very faint/smeared/weird
image
  • selecting all items, cutting and pasting them into the same location -> select replace -> all files disappear
  • Create a new file, leave name at default. Edit the file and save. Create a new file, leave default name -> previously edited file is overwritten
  • Operations/History Window is open -> right click into file browser opens regular browser right click menu
  • Having a scrolling list and inside only show 8 items
image
  • tabs seem to share what is selected inside of them. If I select items, move into the same folder inside a new tab the selection in the old tab changes

Preview

  • When editing a file so its too large ~600000 lines errors toast is "Failed to save file" -> why not tell user the reason error console shows? (too large)

@F3l1x1vo

F3l1x1vo commented Sep 23, 2026

Copy link
Copy Markdown
Collaborator

@Bohreromir I've implemented most of your suggestions in 9e2ec68. I have two points to address:

When creating a new file paste (ctrl+p) does not work in the filename field

Ctrl + P is not a valid shortcut. File paste works on Ctrl + V.

Fonts look very faint/smeared/weird

It's the regular bold disabled font we use everywhere. I don't disagree that it appears slightly blurred if you look closely in darkmode but it's clearly legible. This was accepted from the day we first did a mockup with the Stackable Team of the storage browser.

@Bohreromir

Bohreromir commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

@F3l1x1vo Whoops my bad. I meant using ctrl+v into the field for the new file name

@F3l1x1vo

F3l1x1vo commented Sep 23, 2026

Copy link
Copy Markdown
Collaborator

I meant using ctrl+v into the field for the new file name

There's a conflict there with the regular pasting of text. If the user wants to copy and paste a filename he copied from outside the browser for example, a file in the clipboard of the storage browser would be pasted into that field instead of his text. This pasting of filenames by the clipboard is a very niche and weird interaction that I would suggest to leave out.

Bohreromir
Bohreromir requested changes Sep 23, 2026
View reviewed changes

@Bohreromir Bohreromir left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some more

Comment thread src/lib/server/db.ts
Comment thread src/lib/storage/schemas.ts Outdated
Comment thread src/lib/server/storage/operations.ts
Comment thread e2e/support/db-migrations.setup.ts
Comment thread src/lib/server/db.ts Outdated
Comment thread docs/DATABASE.md Outdated
Comment thread src/lib/server/storage/archive.ts Outdated
Comment thread src/lib/server/storage/archive.ts Outdated
Comment thread src/lib/storage/clipboard.svelte.ts
Comment thread src/lib/components/storage/sidebar/BucketList.svelte Outdated
Bohreromir
Bohreromir requested changes Sep 28, 2026
View reviewed changes
Comment thread src/lib/server/storage/encryption-key.ts
Comment thread docs/DATABASE.md
Comment thread src/lib/server/storage/archive.ts Outdated
Comment thread src/lib/server/storage/archive.ts Outdated
Comment thread src/lib/server/storage/archive.ts Outdated
@F3l1x1vo

F3l1x1vo commented Sep 30, 2026

Copy link
Copy Markdown
Collaborator

@Bohreromir I've added rar support via node-unrar-js in 68cac8e. Please check it out and tell me if it's acceptable to Stackable.

Bohreromir
Bohreromir requested changes Oct 1, 2026
View reviewed changes
Comment thread package.json Outdated
Comment thread src/lib/components/storage/explorer/file-icon/iconConfig.ts Outdated
Bohreromir
Bohreromir requested changes Oct 2, 2026
View reviewed changes
Comment thread .npmrc Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lfrancke lfrancke lfrancke requested changes
@Bohreromir Bohreromir Bohreromir requested changes
@F3l1x1vo F3l1x1vo Awaiting requested review from F3l1x1vo

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Epic: S3 File Browser v1

5 participants

@dklOrdix @F3l1x1vo @Bohreromir @lfrancke