Conversation
zach-klippenstein
approved these changes
Mar 30, 2021
zach-klippenstein
left a comment
zach-klippenstein
left a comment
Contributor
There was a problem hiding this comment.
LGTM, but I'll let defer merging to @akpala.
Contributor
There was a problem hiding this comment.
Also, @maxbeatty i think you need to run the generator to update the HTML files too.
./generate.py
Author
|
I didn't intend to change anything about the published site, only add some licenses to the repo itself. |
Contributor
|
Ah, for some reason I was thinking README.md was used in the generated site. My bad. |
Retro64XYZ
approved these changes
Apr 15, 2021
Retro64XYZ
left a comment
Retro64XYZ
left a comment
There was a problem hiding this comment.
This looks good. Glad to see the addition of a license here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
requested by @akpala