NoSuchMethodException when registering class instances on Android 2.2 & 2.3.7 #37

Activity

1. JakeWharton commented on Nov 12, 2012

   

   JakeWharton

   on Nov 12, 2012

   Collaborator

   More actions

   Er, this would indicate a seriously broken version of Dalvik since Class#getDeclaredMethods() has been available since API 1. Does this happen on emulators, phones, or both? Is the device running a custom ROM from an OEM (e.g., HTC Sense, MotoBlur, TouchWiz, etc.)?
2. klevi commented on Nov 12, 2012

   

   klevi

   on Nov 12, 2012

   Author

   More actions

   1st device: LG P500 running Android OS 2.2 (this should be stock Android)
   2nd device: Orange Boston - Gigabyte G1305 running CyanogenMod 7.2 (Android 2.3.7)

   Since they are very different, the problem should be something else. Note that I'm using your ActionBarSherlock library, but that shouldn't be an issue.

   Edit 1: just checked it on a Motorola Milestone running 2.2.1 ... same problem
   Edit 2: The HomeActivity extends SherlockFragmentActivity (maybe there's something wrong when extending onResume?)
3. swankjesse commented on Nov 12, 2012

   

   swankjesse

   on Nov 12, 2012

   Contributor

   More actions

   This looks a lot like the cunning android bug I encountered in August.
4. klevi commented on Nov 13, 2012

   

   klevi

   on Nov 13, 2012

   Author

   More actions

   I have no listeners in xml files, and also checked the project with Lint, but there's no API call that should have any backwards compatibility problem. Any other ideas?

   Edit: I red swankjesse's post over and over, and finally managed to solve the problem. Turns out I had a widget available from API level 11 in my code. Event if it was only declared, not used within the code where the app was running on older Android versions, the app was crashing. Don't know why exactly the exception was thrown pointing to this library, but probably because of the process described by swankjesse in the blog post above.

   Thanks for the support, and sorry because of the false alarm.
   Keep up the good work!
5. JakeWharton

   closed this as completedon Jan 11, 2013
6. tyvsmith commented on Feb 18, 2014

   

   tyvsmith

   on Feb 18, 2014

   More actions

   This should be re-opened. Otto uses reflection to look for producers. If a method class takes a parameter that didn't exist on the version being tested, it'll fail.

   Caused by: java.lang.NoSuchMethodException
               at java.lang.Class.getDeclaredMethods(Native Method)
               at java.lang.ClassCache.getDeclaredMethods(ClassCache.java:140)
               at java.lang.Class.getDeclaredMethods(Class.java:757)            
               at java.lang.Class.getDeclaredMethods(Class.java:757)
               at com.squareup.otto.AnnotatedHandlerFinder.loadAnnotatedMethods(AnnotatedHandlerFinder.java:52)
               at com.squareup.otto.AnnotatedHandlerFinder.findAllProducers(AnnotatedHandlerFinder.java:119)
               at com.squareup.otto.HandlerFinder$1.findAllProducers(HandlerFinder.java:33)
               at com.squareup.otto.Bus.register(Bus.java:187)
   

   For example, assuming the containing class contains a register call, this method existing will cause Otto to fail on 2.3 (without being called).

       @TargetApi(Build.VERSION_CODES.HONEYCOMB)
       public JsonReader testMethod(JsonReader test) {
           return null;
       }
   
7. JakeWharton commented on Feb 18, 2014

   

   JakeWharton

   on Feb 18, 2014

   Collaborator

   More actions

   @tyvsmith What would you expect the library to do in that case? Without a fundamental re-write we're forced to use reflection.
8. tyvsmith commented on Feb 18, 2014

   

   tyvsmith

   on Feb 18, 2014

   More actions

   @JakeWharton Agreed that a fundamental re-write would resolve this, but short of that, documenting this gotcha is probably important. Aside from that, I'd experiment with catching the exception and continuing. A developer shouldn't have a method that would cause this behavior that would also be subscribing or producing on that version of Android.
9. tyvsmith commented on Feb 19, 2014

   

   tyvsmith

   on Feb 19, 2014

   More actions

   The workaround we're using for now is encouraging the use of inner classes and interface implementations to subscribe and produce, thus preventing the parent from being iterated on and containing the event bus logic to a guaranteed area.

   Something like this in a base class:

       public interface EventBusMethods { }
       protected abstract Bus getEventBus();
       protected abstract EventBusMethods getEventBusMethods();
   
       public BaseClass() {
           getEventBus().register(getEventBusMethods());
       }
   
10. dbrant

    added a commit that references this issue on Jan 7, 2015

    Get selected text from the WebView.

    ...

    e9c5c09