Add join support to EET and MySQL - #1366
Closed
tlmorgan24 wants to merge 3 commits into
Closed
tlmorgan24 wants to merge 3 commits into
tlmorgan24 wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds join support to EET DML, complementing the existing join support that the EET SELECT oracle has. This PR also ensures MySQL is able to generate joins to make use of this.
MySQL had existing infrastructure for joins, but it was not being exercised (
getRandomJoinClauses()was a stub returning an empty list). I replaced the stub so both EET and other oracles can exercise joins in MySQL. I also discovered a bug inMySQLProviderwhich meant multi-table databases were not actually being generated, which was another barrier preventing test cases with joins from being created. I fixed this too, and as my part of the evaluation work in my report, I verified that MySQL with EET and EET DML is now correctly exercising joins.