You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Sorry for the delay in reviewing. I have been traveling and did not see this PR.
It seems given that EXTRACT has a special syntax, and the current implementation introduces some additional checks at multiple places to deal with them. I think this is not ideal in terms of OOP. Would it be possible to have a special subclass and implement the variability in methods that are overwritten?
Sorry for the delay in reviewing. I have been traveling and did not see this PR.
It seems given that EXTRACT has a special syntax, and the current implementation introduces some additional checks at multiple places to deal with them. I think this is not ideal in terms of OOP. Would it be possible to have a special subclass and implement the variability in methods that are overwritten?
I just noticed that there is a test failure (" time zone "g+zvi" not recognized"). Could you run the changed implementation for longer to check whether there are other errors that need to be added as expected errors?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1242