Repository navigation
fix(models): restore external IDs on Track and Album - #472
Merged
dargmuesli merged 2 commits intoSep 1, 2026
Merged
dargmuesli merged 2 commits into
dargmuesli merged 2 commits into
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## docs/migration/add-v9-to-v10-guide #472 +/- ##
========================================================================
+ Coverage 48.73% 48.93% +0.19%
- Complexity 712 716 +4
========================================================================
Files 325 325
Lines 11177 11195 +18
Branches 1317 1319 +2
========================================================================
+ Hits 5447 5478 +31
+ Misses 4711 4696 -15
- Partials 1019 1021 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dargmuesli
merged commit Sep 1, 2026
3ce3498
into
docs/migration/add-v9-to-v10-guide
7 checks passed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Album.getExternalIds()andTrack.getExternalIds()disappeared in the spec sync. The specification still listsexternal_idsas a required property on both objects, and unlikeavailable_markets,popularityandlinked_fromit carries nodeprecated: true, so the removal looks like collateral rather than a decision. It also leftExternalIdin the tree with nothing returning it.This restores the field, the getter, the builder setter and the JSON parsing on both objects, matching how they looked in 9.4.0. ISRC, EAN and UPC codes are reachable again.
Both request tests now assert the parsed value rather than just non-null:
GBFFP0300052for the track fixture and5099749994324for the album fixture. Setting either expectation to a wrong value fails both the sync and async paths.The second commit drops the paragraph in the migration guide that reported this removal, so the guide stays correct whichever way the two PRs land.
395 tests pass, the javadoc build is clean and
ci/check-docs.pypasses.