Skip to content

feat: add common interfaces #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dargmuesli merged 5 commits into from
Apr 29, 2026
Merged

feat: add common interfaces #457

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
557f20d
add common interfaces
fm-sys Apr 13, 2026
fcf3d08
apply copilot review suggestion
fm-sys Apr 13, 2026
01f413e
add getItems to IPlaylist to allow querying number of total tracks
fm-sys Apr 13, 2026
2b41d3e
refactor: sort imports
dargmuesli Apr 29, 2026
57276dd
fix(playlist): allow to extend the has-total interface
dargmuesli Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix(playlist): allow to extend the has-total interface
  • Loading branch information
@dargmuesli
dargmuesli committed Apr 29, 2026
commit 57276ddd270bef30951e7189f9909894ecc9d232
9 changes: 7 additions & 2 deletions src/main/java/se/michaelthelin/spotify/model_objects/interfaces/IPlaylist.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,13 @@
*
* <p>This interface provides a common base for {@link Playlist} and
* {@link PlaylistSimplified} objects.
*
* @param <T> The concrete type of the items/tracks metadata object. {@link Playlist} uses
* {@link se.michaelthelin.spotify.model_objects.specification.Paging} and
* {@link PlaylistSimplified} uses
* {@link se.michaelthelin.spotify.model_objects.miscellaneous.PlaylistTracksInformation}.
*/
public interface IPlaylist {
public interface IPlaylist<T extends IHasTotal> {
/**
* Check whether the owner allows other users to modify the playlist.
*
Expand Down Expand Up @@ -93,7 +98,7 @@ public interface IPlaylist {
*
* @return Item information containing total count.
*/
IHasTotal getItems();
T getItems();

/**
* Get the snapshot ID, the version identifier for the current playlist. Can be supplied in other requests to target
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/se/michaelthelin/spotify/model_objects/specification/Playlist.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
* Playlist objects</a> by building instances from this class.
*/
@JsonDeserialize(builder = Playlist.Builder.class)
public class Playlist extends AbstractModelObject implements IPlaylist {
public class Playlist extends AbstractModelObject implements IPlaylist<Paging<PlaylistTrack>> {
/** Whether the playlist is collaborative. */
private final Boolean collaborative;
/** The description of the playlist. */
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/se/michaelthelin/spotify/model_objects/specification/PlaylistSimplified.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
* simplified Playlist objects</a> by building instances from this class.
*/
@JsonDeserialize(builder = PlaylistSimplified.Builder.class)
public class PlaylistSimplified extends AbstractModelObject implements ISearchModelObject, IPlaylist {
public class PlaylistSimplified extends AbstractModelObject implements ISearchModelObject, IPlaylist<PlaylistTracksInformation> {
/** Whether the playlist is collaborative. */
private final Boolean collaborative;
/** The description of the playlist. */
Expand Down
Loading