Skip to content

themes/basic/defindex.html should be changed for html5 friendly #2986

Closed

Description

@hhsprings

themes/basic/defindex.html uses align attribute for table and width attribute for td, but these are invalid as html5.

Activity

  1. added this to the 1.5 milestone on Sep 30, 2016
  2. tk0miya commented on Oct 7, 2016

    @tk0miya
    Member

    Fixed.
    Thank you for reporting

  3. tk0miya commented on Oct 7, 2016

    @tk0miya
    Member

    After fixed, I investigated about defindex.html.
    It was used to keep compatibility to before Sphinx-0.2.
    And no longer used in current source code.

    So finally, I removed it.
    Thanks,

  4. leplatrem commented on Oct 19, 2016

    @leplatrem

    @tk0miya, removing this defindex.html is a breaking change IMO ;) Our documentation suddenly broke with Sphinx 1.5a2

    I thought we were the only ones inheriting that internal file, but apparently thousands of projects rely on it too: https://github.com/search?q=defindex.html&type=Code&utf8=%E2%9C%93

  5. tk0miya commented on Nov 4, 2016

    @tk0miya
    Member

    Hmm... that's strange situation.
    Okay, I will restore it again.
    But, the status is still not changed. defindex.html is no longer used by default. so I will emit deprecation warning to defindex.html.

  6. reopened this on Nov 4, 2016
  7. self-assigned this
    on Nov 5, 2016
  8. added a commit that references this issue on Nov 18, 2016
    8a1703c
  9. tk0miya commented on Nov 18, 2016

    @tk0miya
    Member

    I restored defindex.html and add deprecation warning.
    Thanks,

  10. added a commit that references this issue on Jul 9, 2021
  11. locked as resolved and limited conversation to collaborators on Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions