Skip to content

fix(shared): decode local repository paths from file:// clone URLs #1690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
breken-ai wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix(shared): decode local repository paths from file:// clone URLs #1690

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f5a356f
fix(shared): decode local repository paths from file:// clone URLs
breken-ai Sep 25, 2026
35ca455
docs: add changelog entry for #1690
breken-ai Sep 26, 2026
01eac55
fix(shared): encode local repository file URLs
breken-ai Sep 27, 2026
3288fc8
fix(shared): preserve legacy percent paths
breken-ai Sep 27, 2026
a91b67a
fix(shared): normalize legacy Windows file URLs
breken-ai Sep 27, 2026
0dc9619
test(shared): verify legacy Windows path fallback
breken-ai Sep 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test(shared): verify legacy Windows path fallback
  • Loading branch information
@breken-ai
breken-ai committed Sep 27, 2026
commit 0dc961916e2c336d0078378deb582448defc3770
10 changes: 8 additions & 2 deletions packages/shared/src/utils.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,9 +134,15 @@ describe('getRepoPath', () => {
test(
'normalizes legacy Windows file URL pathnames before checking the filesystem',
() => {
const cloneUrl = new URL('file://C:\\Users\\me\\100%20Free');
const nativePath = 'C:\\Users\\me\\100%20Free';
const legacyPathname = cloneUrl.pathname;

expect(legacyPathname).toBe('/C:/Users/me/100%20Free');
expect(path.win32.normalize(legacyPathname)).not.toBe(nativePath);
expect(
normalizeLegacyFileURLPathname('/C:/Users/me/100%20Free', 'win32'),
).toBe('C:\\Users\\me\\100%20Free');
normalizeLegacyFileURLPathname(legacyPathname, 'win32'),
).toBe(nativePath);
expect(
normalizeLegacyFileURLPathname('/repos/100%20Free', 'win32'),
).toBe('/repos/100%20Free');
Expand Down