Skip to content

fix(web): disambiguate MCP language model selection for ask_codebase #1414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Harsh23Kashyap wants to merge 10 commits into from
Closed

fix(web): disambiguate MCP language model selection for ask_codebase #1414

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
5b16723
fix(web): resolve MCP language model lookups without displayName
Jul 2, 2026
19bb076
test(web): cover MCP language model disambiguation
Jul 2, 2026
c0b1aeb
chore: add changelog entry for MCP language model selection fix
Jul 2, 2026
f638723
refactor(web): extract MCP language model selector for unit tests
Jul 4, 2026
00a4bda
test(web): cover not-configured branch in MCP language model selector
Jul 5, 2026
392ad3c
refactor(web): use discriminated union for selectConfiguredLanguageMo…
Jul 5, 2026
9cacd15
Merge upstream/main into Harsh23Kashyap/fix-mcp-language-model-matchi…
Harsh23Kashyap Jul 19, 2026
e5f2eae
Merge branch 'main' into Harsh23Kashyap/fix-mcp-language-model-matchi…
Harsh23Kashyap Jul 21, 2026
5ce5b68
Merge branch 'main' into Harsh23Kashyap/fix-mcp-language-model-matchi…
Harsh23Kashyap Jul 22, 2026
57e7cef
Merge branch 'main' into Harsh23Kashyap/fix-mcp-language-model-matchi…
Harsh23Kashyap Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test(web): cover not-configured branch in MCP language model selector
  • Loading branch information
Harsh Kashyap @Harsh23Kashyap
Harsh Kashyap authored and Harsh23Kashyap committed Jul 17, 2026
commit 00a4bdaa6156b6e0604aab649bd6e6c6b5da0f3b
17 changes: 17 additions & 0 deletions packages/web/src/ee/features/mcp/askCodebase.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,23 @@ describe("selectConfiguredLanguageModel", () => {
expect(result).toEqual({ languageModelConfig: secondModel });
});

it("returns an error when no configured model matches provider and model", () => {
const configuredModel = createConfiguredModel();

const result = selectConfiguredLanguageModel(
[configuredModel],
{ provider: 'openai', model: 'gpt-5' }
);

expect(result).toEqual({
error: {
statusCode: StatusCodes.BAD_REQUEST,
errorCode: ErrorCode.INVALID_REQUEST_BODY,
message: "Language model 'openai/gpt-5' is not configured.",
},
});
});

it("returns a disambiguation error when multiple configured models match", () => {
const firstModel = createConfiguredModel({ displayName: 'Claude Opus 4.7 (slow)' });
const secondModel = createConfiguredModel({ displayName: 'Claude Opus 4.7 (fast)' });
Expand Down