Skip to content

Add new rule: dont_create_a_return_var #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
solid-dmytrotkachuk merged 12 commits into from
Oct 2, 2025
Merged

Add new rule: dont_create_a_return_var #220

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
f0f42de
Issue #92, new rule `dont_create_a_return_var`:
tozpeak Sep 30, 2025
479c053
Issue #92: added rule in analysis_options.yaml
tozpeak Oct 1, 2025
5f4a8f9
Issue #92: added new test case
tozpeak Oct 1, 2025
09536d5
Issue #92: added naive implementation for dont_create_a_return_var_rule
tozpeak Oct 1, 2025
0e11f8f
Issue #92: fixed conflicting lints in test
tozpeak Oct 1, 2025
1c12bbb
Issue #92: added test case where return var defined from mutable, but…
tozpeak Oct 1, 2025
477ae52
Issue #92: implemented advanced rule with visitor, checking where var…
tozpeak Oct 1, 2025
5390736
Issue #92: fixed formatting with 'dart format'
tozpeak Oct 2, 2025
89e940a
Issue #92: changed if chain to switch statement (more readable)
tozpeak Oct 2, 2025
6d61a79
Issue #92: renaming rule to avoid_unnecessary_return_variable
tozpeak Oct 2, 2025
9d32869
Issue #92: small readability improvements
tozpeak Oct 2, 2025
c1e0d83
#Issue 92: renamed test file accordingly
tozpeak Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Issue #92: added rule in analysis_options.yaml
  • Loading branch information
@tozpeak
tozpeak committed Oct 1, 2025
commit 479c0538470582b9fa5aec949bf1b99153167081
1 change: 1 addition & 0 deletions lib/analysis_options.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ custom_lint:
- cyclomatic_complexity:
max_complexity: 10

- dont_create_a_return_var
- double_literal_format
Comment thread
solid-dmytrotkachuk marked this conversation as resolved.
Resolved
Comment thread
solid-dmytrotkachuk marked this conversation as resolved.
Resolved

- function_lines_of_code:
Expand Down
1 change: 1 addition & 0 deletions lint_test/analysis_options.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,3 +89,4 @@ custom_lint:
- required
- nullable
- default
- dont_create_a_return_var