Skip to content

Make it possible to exclude extensions, entities and mixins from prefer_match_file_name rule #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yurii-prykhodko-solid merged 21 commits into from
May 5, 2025
Merged

Make it possible to exclude extensions, entities and mixins from prefer_match_file_name rule #206

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
ea40baa
prefer_match_file_name ignore extensions
iimironchuk Apr 28, 2025
261d661
extension ignored by parameter
iimironchuk Apr 28, 2025
969bfc3
ignore some entity by exclude_entity
iimironchuk Apr 29, 2025
5ef5a49
ignore some entity by exclude_entity
iimironchuk Apr 29, 2025
6c9207d
ignore some entity by exclude_entity final variant
iimironchuk Apr 29, 2025
f572aff
Fix formatting
iimironchuk Apr 29, 2025
ff56afc
now the logic of ignoring entities can be reused
iimironchuk Apr 29, 2025
3960ca4
suggested changes done
iimironchuk Apr 29, 2025
fdd18e3
added exclude_entity to analysis_options.yaml
iimironchuk Apr 30, 2025
56c400e
fix in CHANGELOG
iimironchuk Apr 30, 2025
90a987a
separate test case file + several declarations added
iimironchuk Apr 30, 2025
988f69f
rm unused import
May 5, 2025
bf85077
Use Set for O(1) lookups
May 5, 2025
c320343
Add more test cases, do not advertise class support
May 5, 2025
b775620
Expand changelog entry
May 5, 2025
1e0d2a7
revert lib/analysis_options.yaml change
May 5, 2025
012ee33
revert lint_test/analysis_optinos.yaml change
May 5, 2025
a2f585d
rm obsolete comment
May 5, 2025
51c8a3a
rm custom_lint dependency from test package
May 5, 2025
3cd0752
rm duplicate rule
May 5, 2025
8bf640e
fmt
May 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use Set for O(1) lookups
  • Loading branch information
Yurii Prykhodko Yurii Prykhodko
Yurii Prykhodko authored and Yurii Prykhodko committed May 5, 2025
commit bf85077d4f0a5b3c98cbe51d0b76f6c09cc642a6
6 changes: 3 additions & 3 deletions lib/src/common/parameters/excluded_entities_list_parameter.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import 'package:analyzer/dart/ast/ast.dart';
/// - enum
class ExcludedEntitiesListParameter {
/// The parameter model
final List<String> excludedEntityNames;
final Set<String> excludedEntityNames;

/// A common parameter key for analysis_options.yaml
static const String excludeEntityKey = 'exclude_entity';
Expand All @@ -25,11 +25,11 @@ class ExcludedEntitiesListParameter {
final raw = json['exclude_entity'];
if (raw is List) {
return ExcludedEntitiesListParameter(
excludedEntityNames: List<String>.from(raw),
excludedEntityNames: Set<String>.from(raw),
);
}
return ExcludedEntitiesListParameter(
excludedEntityNames: [],
excludedEntityNames: {},
);
}

Expand Down