Skip to content

I166 #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sufftea merged 7 commits into from
May 2, 2024
Merged

I166 #170

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
576869e
Rename to avoid_debug_print_in_release
sufftea Apr 29, 2024
503589f
Implement kDebugMode check
sufftea Apr 29, 2024
8324d8c
add doc comments
sufftea Apr 29, 2024
da7464e
Look for the checks all the way up the tree; check for !kReleaseMode …
sufftea Apr 29, 2024
94544d1
Refactor & fix issues
sufftea Apr 30, 2024
294157e
fix comments
sufftea Apr 30, 2024
b94a8fc
fix more comments
sufftea May 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Rename to avoid_debug_print_in_release
  • Loading branch information
@sufftea
sufftea committed Apr 29, 2024
commit 576869e358798625533a461b2d26b143a1d786be
2 changes: 1 addition & 1 deletion lint_test/analysis_options.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ custom_lint:
- newline_before_return
- no_empty_block
- no_equal_then_else
- avoid_debug_print
- avoid_debug_print_in_release
- prefer_early_return
- member_ordering:
alphabetize: true
Expand Down
8 changes: 4 additions & 4 deletions lint_test/avoid_debug_print_test.dart/avoid_debug_print_prefix_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,17 @@

import 'package:flutter/foundation.dart' as f;

/// Test the avoid_debug_print
/// Test the avoid_debug_print_in_release
void avoidDebugPrintTest() {
// expect_lint: avoid_debug_print
// expect_lint: avoid_debug_print_in_release
f.debugPrint('');

// expect_lint: avoid_debug_print
// expect_lint: avoid_debug_print_in_release
final test = f.debugPrint;

test('test');

// expect_lint: avoid_debug_print
// expect_lint: avoid_debug_print_in_release
final test2 = f.debugPrint('');

debugPrint();
Expand Down
10 changes: 5 additions & 5 deletions lint_test/avoid_debug_print_test.dart/avoid_debug_print_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,22 +2,22 @@

import 'package:flutter/foundation.dart';

/// Test the avoid_debug_print
/// Test the avoid_debug_print_in_release
void avoidDebugPrintTest() {
// expect_lint: avoid_debug_print
// expect_lint: avoid_debug_print_in_release
debugPrint('');

// expect_lint: avoid_debug_print
// expect_lint: avoid_debug_print_in_release
final test = debugPrint;

var test2;

// expect_lint: avoid_debug_print
// expect_lint: avoid_debug_print_in_release
test2 = debugPrint;

test.call('test');

// expect_lint: avoid_debug_print
// expect_lint: avoid_debug_print_in_release
final test3 = debugPrint('');

someOtherFunction();
Expand Down