Skip to content

Fixed avoid_unused_parameters #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yurii-prykhodko-solid merged 8 commits into from
Mar 14, 2024
Merged

Fixed avoid_unused_parameters #140

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2acc45c
Fixed avoid_unused_parameters
Viktor-Mudrytskyi Mar 13, 2024
7d6034c
PR issues
Viktor-Mudrytskyi Mar 13, 2024
419db99
chnages toward named params
Viktor-Mudrytskyi Mar 13, 2024
268959c
fix doc mistake
Viktor-Mudrytskyi Mar 13, 2024
8cb4c2f
fix dry
Viktor-Mudrytskyi Mar 13, 2024
613fda1
PR fix
Viktor-Mudrytskyi Mar 13, 2024
6df8c5c
Update CHANGELOG.md
yurii-prykhodko-solid Mar 13, 2024
9101580
Merge branch 'master' into fix_typedef_for_avoid_unused_param_lint
yurii-prykhodko-solid Mar 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
PR issues
  • Loading branch information
@Viktor-Mudrytskyi
Viktor-Mudrytskyi committed Mar 13, 2024
commit 7d6034cabcc242f1f4a568af75c3a2574291c7db
4 changes: 2 additions & 2 deletions lib/src/lints/avoid_unused_parameters/avoid_unused_parameters_rule.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import 'package:solid_lints/src/models/solid_lint_rule.dart';
/// ```dart
/// typedef MaxFun = int Function(int a, int b);
/// final MaxFun bad = (int a, int b) => 1; // LINT
/// final MaxFun tetsFun = (int a, int b) { // LINT
/// final MaxFun testFun = (int a, int b) { // LINT
/// return 4;
/// };
/// void fun(String x) {} // LINT
Expand All @@ -34,7 +34,7 @@ import 'package:solid_lints/src/models/solid_lint_rule.dart';
/// ```dart
/// typedef MaxFun = int Function(int a, int b);
/// final MaxFun good = (int a, int b) => a + b;
/// final MaxFun tetsFun = (int a, int b) {
/// final MaxFun testFun = (int a, int b) {
/// return a + b;
/// };
/// void fun(String _) {} // Replacing with underscores silences the warning
Expand Down
26 changes: 26 additions & 0 deletions lint_test/avoid_unused_parameters_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ import 'package:flutter/material.dart';

typedef MaxFun = int Function(int a, int b);

typedef Named = String Function({required String text});

// expect_lint: avoid_unused_parameters
final MaxFun bad = (int a, int b) => 1;

Expand All @@ -23,6 +25,30 @@ final MaxFun goodMax = (int a, int b) {
return a + b;
};
Comment thread
yurii-prykhodko-solid marked this conversation as resolved.
Resolved

// expect_lint: avoid_unused_parameters
final Named _named = ({required text}) {
return '';
};
Comment thread
yurii-prykhodko-solid marked this conversation as resolved.
Resolved

final Named _named2 = ({required text}) {
return text;
};

// expect_lint: avoid_unused_parameters
final Named _named3 = ({required text}) => '';

final Named _named4 = ({required text}) => text;

// expect_lint: avoid_unused_parameters
final optional = (int a, [int b = 0]) {
return a;
};

// expect_lint: avoid_unused_parameters
final named = (int a, {required int b, int c = 0}) {
return a + c;
};

// good
var k = (String g) {
return g;
Expand Down