Skip to content

Fix ArrayBuffer detached error with uWebSockets.js #5331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ruochenjia wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix ArrayBuffer detached error with uWebSockets.js #5331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix ArrayBuffer detached error with uWebSockets.js
  • Loading branch information
@ruochenjia
ruochenjia committed Apr 20, 2025
commit 4af95592f54c4405d7335d5be96199cb584d330f
2 changes: 1 addition & 1 deletion packages/engine.io/lib/userver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ export class uServer extends BaseServer {
},
message: (ws, message, isBinary) => {
ws.getUserData().transport.onData(
isBinary ? message : Buffer.from(message).toString(),
isBinary ? message.slice(0, message.byteLength) : Buffer.from(message).toString(),
);
},
close: (ws, code, message) => {
Expand Down
1 change: 1 addition & 0 deletions packages/engine.io/wrapper.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,5 @@ export {
attach,
parser,
protocol,
uServer
} from "./build/engine.io.js";