fix(web): stop the split tile busy timer outliving its download - #1663
Merged
Merged
Conversation
handleDownloadTile started a 500 ms setTimeout to clear the busy flag and never cancelled it. A second tile clicked within 500 ms had its flag cleared by the first tile's timer, and the timer still fired after the panel unmounted. Hold the timer id in a ref, clear the previous timer before starting a new one, and clear it on unmount. Fixes snapotter-hq#1662
Owner
|
Review notes before merge. Both new tests fail against the old Nothing blocking. Three smaller things were looked at and left alone:
|
Owner
|
Thanks @drakeo338. A second tile clicked within half a second now keeps its busy animation until its own timer runs out, and the split panel no longer leaves that timer behind when it unmounts. It merged as you sent it; both new tests fail without the fix, which is what sold me. It'll ship in the next release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #1662.
handleDownloadTilestarted a 500 ms timer to clear the busy flag and never cancelled it. Clicking a second tile within 500 ms had its busy flag cleared early by the first tile's timer, and the timer still fired after the panel unmounted. The timer id now lives in a ref, is cleared before a new one starts, and is cleared on unmount.Type of change
Checklist
pnpm test)pnpm typecheck)Screenshots (if applicable)
No visual change.
Only the touched test file was run on this commit (19 passed); the full suite, Biome and typecheck were not run, and the CLA is still to be signed via the bot.