Repository navigation
Conversation
Contributor
|
This pull request does not contain a staged changelog entry. To create one, use the Make sure that the description is appropriate for a changelog entry and that the proper feature type is used. See |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Add rpcv2Cbor protocol test vectors that pin the on-the-wire CBOR encoding for previously untested cases: multibyte UTF-8 text (a string value and a map key, asserting the text-string length is a UTF-8 byte count, not a UTF-16 code-unit count); integer-encoded floating point (float/double deserialized from CBOR integers whose 2-, 4-, and 8-byte argument markers collide with the FLOAT16/32/64 minor values, asserting dispatch on the major type first); and negative-integer timestamps (pre-epoch values as CBOR negative integers, single- and multi-byte, asserting the sign is preserved).
These encodings are valid per RFC 8949 and the rpcv2Cbor spec but were not covered by the shared suite. The gaps let non-interoperable behavior pass unnoticed — the underlying defects survived round-trip tests because the same implementation encoded and decoded them consistently, so only wire-format assertions catch them. Pinning the wire bytes in the shared suite protects every SDK that consumes it against regressions.
Testing
./gradlew :smithy-protocol-tests:build— the model validates and the projection builds; each test body was decoded back to CBOR and checked against its paramsLinks
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.