Repository navigation
Conversation
Specifically, the following DeprecationWarning due to changes in Python 3.7 [1] /home/yen/Projects/python-frozendict/frozendict/__init__.py:16: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working class frozendict(collections.Mapping): [1] python/cpython#5460
ppolewicz
approved these changes
Nov 22, 2018
Author
|
Hi I noticed that this pull request is approved but not merged. Is there anything left to be fixed? |
Author
|
@slezica ping |
Author
|
I created this pull request to make ycmd compatible with future Python versions. Now I switched to coc.nvim, so the issue is no longer relevant. I hereby declare the commit cd5b529 licensed as MIT, the same license as python-frozendict. If anyone else want to continue the work, feel free to take my patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specifically, the following DeprecationWarning due to changes in Python
3.7 [1]
Tested with:
[1] python/cpython#5460