Skip to content

chore: replace sleep-based polling with Event synchronization in tests #1467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WilliamBergamin merged 7 commits into from
Mar 23, 2026
Merged

chore: replace sleep-based polling with Event synchronization in tests #1467

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0a339e9
chore: fix warnings in tests
WilliamBergamin Mar 20, 2026
12c09ea
chore: replace deprecated httpx data param with content in tests
WilliamBergamin Mar 20, 2026
45a87bf
chore: fix ssl warning in tests
WilliamBergamin Mar 20, 2026
8d8c3d2
chore: fix django warnings in tests
WilliamBergamin Mar 20, 2026
3c96e48
chore: fix some test warnings
WilliamBergamin Mar 20, 2026
f64b211
Merge branch 'main' into imporve-unit-test-around-assistant
WilliamBergamin Mar 20, 2026
21d0ad7
revert warning fixes
WilliamBergamin Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: replace deprecated httpx data param with content in tests
  • Loading branch information
@WilliamBergamin
WilliamBergamin committed Mar 20, 2026
commit 12c09eaa459845ab26d92a0ed6710addfe9d1358
8 changes: 4 additions & 4 deletions tests/adapter_tests/starlette/test_fastapi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ async def endpoint(req: Request):
client = TestClient(api)
response = client.post(
"/slack/events",
data=body,
content=body,
headers=self.build_headers(timestamp, body),
)
assert response.status_code == 200
Expand Down Expand Up @@ -138,7 +138,7 @@ async def endpoint(req: Request):
client = TestClient(api)
response = client.post(
"/slack/events",
data=body,
content=body,
headers=self.build_headers(timestamp, body),
)
assert response.status_code == 200
Expand Down Expand Up @@ -182,7 +182,7 @@ async def endpoint(req: Request):
client = TestClient(api)
response = client.post(
"/slack/events",
data=body,
content=body,
headers=self.build_headers(timestamp, body),
)
assert response.status_code == 200
Expand Down Expand Up @@ -254,7 +254,7 @@ async def endpoint(req: Request, foo: str = Depends(get_foo)):
client = TestClient(api)
response = client.post(
"/slack/events",
data=body,
content=body,
headers=self.build_headers(timestamp, body),
)
assert response.status_code == 200
Expand Down
6 changes: 3 additions & 3 deletions tests/adapter_tests/starlette/test_starlette.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ async def endpoint(req: Request):
client = TestClient(api)
response = client.post(
"/slack/events",
data=body,
content=body,
headers=self.build_headers(timestamp, body),
)
assert response.status_code == 200
Expand Down Expand Up @@ -143,7 +143,7 @@ async def endpoint(req: Request):
client = TestClient(api)
response = client.post(
"/slack/events",
data=body,
content=body,
headers=self.build_headers(timestamp, body),
)
assert response.status_code == 200
Expand Down Expand Up @@ -189,7 +189,7 @@ async def endpoint(req: Request):
client = TestClient(api)
response = client.post(
"/slack/events",
data=body,
content=body,
headers=self.build_headers(timestamp, body),
)
assert response.status_code == 200
Expand Down
8 changes: 4 additions & 4 deletions tests/adapter_tests_async/test_async_fastapi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ async def endpoint(req: Request):
client = TestClient(api)
response = client.post(
"/slack/events",
data=body,
content=body,
headers=self.build_headers(timestamp, body),
)
assert response.status_code == 200
Expand Down Expand Up @@ -138,7 +138,7 @@ async def endpoint(req: Request):
client = TestClient(api)
response = client.post(
"/slack/events",
data=body,
content=body,
headers=self.build_headers(timestamp, body),
)
assert response.status_code == 200
Expand Down Expand Up @@ -182,7 +182,7 @@ async def endpoint(req: Request):
client = TestClient(api)
response = client.post(
"/slack/events",
data=body,
content=body,
headers=self.build_headers(timestamp, body),
)
assert response.status_code == 200
Expand Down Expand Up @@ -255,7 +255,7 @@ async def endpoint(req: Request, foo: str = Depends(get_foo)):
client = TestClient(api)
response = client.post(
"/slack/events",
data=body,
content=body,
headers=self.build_headers(timestamp, body),
)
assert response.status_code == 200
Expand Down
6 changes: 3 additions & 3 deletions tests/adapter_tests_async/test_async_starlette.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ async def endpoint(req: Request):
client = TestClient(api)
response = client.post(
"/slack/events",
data=body,
content=body,
headers=self.build_headers(timestamp, body),
)
assert response.status_code == 200
Expand Down Expand Up @@ -143,7 +143,7 @@ async def endpoint(req: Request):
client = TestClient(api)
response = client.post(
"/slack/events",
data=body,
content=body,
headers=self.build_headers(timestamp, body),
)
assert response.status_code == 200
Expand Down Expand Up @@ -189,7 +189,7 @@ async def endpoint(req: Request):
client = TestClient(api)
response = client.post(
"/slack/events",
data=body,
content=body,
headers=self.build_headers(timestamp, body),
)
assert response.status_code == 200
Expand Down