Skip to content

fix(landing): return 404 for unknown library, blog, integration, model, and author slugs - #8587

Merged
waleedlatif1 merged 2 commits into
stagingfrom
fix/landing-404-and-redirect-hygiene
Oct 2, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
fix/landing-404-and-redirect-hygiene

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Oct 2, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Unknown slugs under /library, /blog, /integrations, /models (provider and model), and the library/blog author pages returned 200 with a contradictory index, follow + noindex pair instead of a 404 (soft 404). These segments have a loading.tsx, so rendering an unknown slug streamed the loading shell with a 200 before the page called notFound()
  • Set dynamicParams = false on those routes (every valid slug is known at build time via generateStaticParams), so unknown params 404 before rendering with the section's not-found.tsx. Author pages get generateStaticParams from the authors of published posts. This matches /customers/[slug], which already did this
  • Docs sitemap no longer lists the docs root, which redirects to /introduction (already listed)

Type of Change

  • Bug fix

Testing

  • Ran the app locally: unknown library/blog/integration/model/author slugs now return 404 with the section not-found page; known pages return 200
  • Revert check on the same server: dynamicParams = true → unknown slug 200, false → 404
  • Crawled every library, blog, author, integration, and model URL in the local sitemap: all 531 return 200
  • Model routes generate params from every provider with models (resellers included, matching what the pages render); all 20 provider and 289 model pages return 200 locally, unknown ones 404
  • bun run lint, bun run type-check, bun run check:audits, block-registry check, docs-manifest:check, root bun run test (all passing); /cleanup passes found nothing beyond a comment tightening

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Oct 2, 2026 9:33pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 8 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium risk] Changes how landing pages handle unknown content slugs.

The PR appears safe to merge; no outstanding finding or new actionable issue was identified.

Summary

The PR makes unknown landing-page slugs return 404 before rendering, adds static parameters for author pages, includes resellers in generated model routes, and removes the redirecting docs root from the docs sitemap.

  • The previously reported reseller-route issue is addressed in the current code; its thread is resolved.

Reviews (2) · Last reviewed commit: "fix(landing): pre-render reseller model ..."

Comment thread apps/sim/app/(landing)/models/(shell)/[provider]/page.tsx
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 9 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit c19db87 into staging Oct 2, 2026
34 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/landing-404-and-redirect-hygiene branch October 2, 2026 22:05

This branch was previously deployed

1 inactive deployment
Preview — cb3c2988 Deployed Oct 2, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant