fix(landing): return 404 for unknown library, blog, integration, model, and author slugs - #8587
Merged
Merged
Conversation
…l, and author slugs
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
|
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/library,/blog,/integrations,/models(provider and model), and the library/blog author pages returned 200 with a contradictoryindex, follow+noindexpair instead of a 404 (soft 404). These segments have aloading.tsx, so rendering an unknown slug streamed the loading shell with a 200 before the page callednotFound()dynamicParams = falseon those routes (every valid slug is known at build time viagenerateStaticParams), so unknown params 404 before rendering with the section'snot-found.tsx. Author pages getgenerateStaticParamsfrom the authors of published posts. This matches/customers/[slug], which already did this/introduction(already listed)Type of Change
Testing
dynamicParams = true→ unknown slug 200,false→ 404bun run lint,bun run type-check,bun run check:audits, block-registry check,docs-manifest:check, rootbun run test(all passing);/cleanuppasses found nothing beyond a comment tighteningChecklist
test-auditauthoring gate)