Skip to content

feat(forks): compare last synced source deployments - #8586

Merged
icecrasher321 merged 3 commits into
stagingfrom
codex/fork-sync-comparison
Oct 2, 2026
Merged

icecrasher321 merged 3 commits into
stagingfrom
codex/fork-sync-comparison

Conversation

@icecrasher321

Copy link
Copy Markdown
Collaborator

Summary

  • Add Compare to deployed workflow row menus in fork push/pull settings. Reuse the existing comparison modal for Last Sync → Now, with structured subblock diffs and explicit unavailable states.
  • Advance the Last Sync baseline only when its destination deployment activates. Keep histories separate by fork and direction, preserve them through operation retention, and handle rollback, unlink, and deleted snapshots without guessing a baseline.
  • Pin reviewed source versions and commit mapping choices with the sync transaction. Share deployment admission across internal and v2 sync; expose comparison metadata in preview responses and the generated CLI contract.

Type of Change

  • Feature

Testing

  • Full repository suite on Node 24 with four workers: 349 script tests, 34,650 app tests, and all 19 workspace test tasks passed.
  • 27 real PostgreSQL/HTTP/CLI integration tests; 8 running-app HTTP/CLI/MCP comparison checks; 6 internal fork HTTP checks. Activation, rollback, stale-source, exact-snapshot, and unlink regressions fail when their guards are independently removed.
  • Browser verified Pull and Push menus, readable header-table changes, unavailable/new-workflow states, and an actual push followed by an identical Last Sync → Now comparison.
  • Lint, 58 audits, all workspace type checks, standard generators, fresh migration replay, migration safety, and schema-drift checks passed.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Oct 2, 2026 10:51pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 45 files

Fix all with cubic | Re-trigger cubic

Comment thread apps/sim/lib/workflows/orchestration/deploy.ts Outdated
Comment thread packages/db/schema.ts
@greptile-apps

greptile-apps Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[High risk] Adds database schema and fork sync comparison tracking.

The PR appears safe to merge; no outstanding finding or new actionable issue was identified.

Summary

The PR adds exact source-deployment comparisons to fork sync and records the baseline when the destination deployment activates. It also pins source versions during sync, exposes comparison metadata through preview contracts, and covers activation, rollback, retention, and unlink behavior with integration tests. The follow-up changes document the comparison components, adjust deployment-result checks, and add a provenance lookup index.

Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A[Sync preview] --> B[Pin source deployment]
  B --> C[Admit destination deployment]
  C --> D{Activation succeeds?}
  D -- Yes --> E[Advance Last Sync baseline]
  D -- No --> F[Keep prior baseline]
  E --> G[Compare Last Sync to Now]
  F --> G
Loading

Reviews (3) · Last reviewed commit: "fix(forks): track admitted deployment ou..."

@icecrasher321

Copy link
Copy Markdown
Collaborator Author

@greptile

@icecrasher321

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@icecrasher321 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 49 files

Fix all with cubic | Re-trigger cubic

Comment thread scripts/check-unused-exports.baseline.json
@icecrasher321

Copy link
Copy Markdown
Collaborator Author

@greptile

@icecrasher321

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@icecrasher321 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 49 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@icecrasher321
icecrasher321 merged commit 405cc6a into staging Oct 2, 2026
33 checks passed
@icecrasher321
icecrasher321 deleted the codex/fork-sync-comparison branch October 2, 2026 23:04

This branch was successfully deployed

1 active deployment
Preview — 37afa72f Deployed Oct 2, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant