fix(executor): name the exact field when a Function block reference holds a large value - #8474
waleedlatif1 wants to merge 3 commits into
Conversation
…olds a large value
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
…to pass into the block
|
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Requires human review: Auto-approval blocked because this review re-detected 1 unresolved issue already reported by Cubic.
Re-trigger cubic
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Summary
contents: [<large value>]), the error now names the exact field to reference instead of the generic "This execution value contains nested large values":<file.contents> contains a 10.5 MB value at <file.contents[0]>. Reference that field directly.Select a smaller field, or read it in JavaScript without imports.instead of being pointed at a reference that would fail the same waycontainsLargeValueRef, reads the size already stored on the ref, loads nothing, and only runs when we're about to throwType of Change
Testing
executor/variablessuite (129 tests); 7 new/changed assertions, all red against the previous resolverbun run type-check,bun run lint,bun run check:audits(52/52),docs-manifest:checkChecklist
test-auditauthoring gate)