Skip to content

Remove deprecated properties from directives - #1800

Open
santisoler wants to merge 6 commits into
mainfrom
removals-v0.26.0-directives-props
Open

Remove deprecated properties from directives#1800
santisoler wants to merge 6 commits into
mainfrom
removals-v0.26.0-directives-props

Conversation

@santisoler

@santisoler santisoler commented Sep 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Summary

Remove saveOnDisk argument from SaveOutputDictEveryIteration. Remove the save_txt argument from SaveOutputEveryIteration. Remove the fileName property from SaveEveryIteration. Update tests and examples to use the new on_disk argument instead of save_txt.

PR Checklist

  • If this is a work in progress PR, set as a Draft PR
  • Linted my code according to the style guides.
  • Added tests to verify changes to the code.
  • Added necessary documentation to any new functions/classes following the
    expect style.
  • Marked as ready for review (if this is was a draft PR), and converted
    to a Pull Request
  • Tagged @simpeg/simpeg-developers when ready for review.

Reference issue

What does this implement/fix?

Additional information

@santisoler santisoler added this to the 0.26.0 milestone Sep 10, 2026
@codecov

codecov Bot commented Sep 10, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.73%. Comparing base (bb9067d) to head (7e6d756).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1800      +/-   ##
==========================================
- Coverage   81.75%   81.73%   -0.02%     
==========================================
  Files         422      422              
  Lines       55756    55748       -8     
  Branches     5294     5292       -2     
==========================================
- Hits        45583    45568      -15     
- Misses       8759     8764       +5     
- Partials     1414     1416       +2

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.26.0

Development

Successfully merging this pull request may close these issues.

1 participant

@santisoler