Conversation
- Add Rush globalOverrides for serialize-javascript (^7.0.3), undici (^6.24.0), and PR siddhi-io#40 transitive dependencies - Upgrade webpack-dev-server to ^5.2.1 in si-visualizer - Regenerate common/config/rush/pnpm-lock.yaml with minimal churn resolving all CVEs - Fix XML declaration encoding in HTTPEndpoint.svg from iso-8859-1 to utf-8 - Fix AxiosHeaders type conversion for content-length in fileOperations.ts - Verified monorepo build passes cleanly across all 6 workspaces
kavix
force-pushed
the
fix/remediate-vulnerabilities-issue-41
branch
from
September 13, 2026 18:20
c5c1e0f to
85f4108
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Resolves #41
Remediates the remaining unaddressed npm dependency vulnerabilities reported by Trivy following PR #40.
Goals
serialize-javascript(6.0.2 → ^7.0.3) by overriding transitive versions via RushglobalOverrides.undici(5.29.0 → ^6.24.0, resolving to 6.28.1) via RushglobalOverrideswithout breaking Node 20 runtime compatibility.webpack-dev-server(4.15.2 → ^5.2.1, resolving to 5.2.6) in@wso2/si-visualizer.common/config/rush/pnpm-lock.yamlusingrush updateso that all transitive security overrides take effect in Trivy scans.HTTPEndpoint.svg(iso-8859-1→utf-8) and Axios header type conversion infileOperations.tsto ensure clean monorepo builds.Approach
common/config/rush/pnpm-config.json):Populated
globalOverrideswith:"serialize-javascript": "^7.0.3": Fixes code injection CVEs in Webpack'sterser-webpack-plugin."undici": "^6.24.0": Pinned to the LTS 6.x line (resolves to 6.28.1), fixing SSRF and request smuggling CVEs while avoiding Node 22+webidlincompatibilities.sha.js,form-data,tar,node-forge,dompurify,minimatch,picomatch,brace-expansion,qs,path-to-regexp,js-yaml,yaml,ajv,prismjs,mdast-util-to-hast,on-headers,min-document, andtmp.workspaces/si/si-visualizer/package.json):Bumped
webpack-dev-serverto^5.2.1(resolved to 5.2.6).Executed
node common/scripts/install-run-rush.js update --fullto bake all version resolutions intopnpm-lock.yaml.HTTPEndpoint.svg: Changed declaration toencoding="utf-8"sosvgicons2svgfontcompiles without SAX stream encoding mismatch.fileOperations.ts: Handled AxiosAxiosHeaderstyping forcontent-lengthwith safeString()conversion beforeparseInt.UI Component Development
ui-toolkitcomponents unaffected.Manage Icons
workspaces/common-libs/font-wso2-vscode/src/icons/HTTPEndpoint.svgfromiso-8859-1toutf-8to allow font generation.User stories
N/A
Release note
Remediated remaining Trivy-reported npm dependency vulnerabilities:
serialize-javascriptto 7.xundicito 6.28.1webpack-dev-serverto 5.2.xDocumentation
N/A — Security and internal build dependency remediation; no changes to user-facing functionality or extension APIs.
Training
N/A
Certification
N/A
Marketing
N/A
Automation tests
node common/scripts/install-run-rush.js buildpasses across all 6 workspaces (@wso2/si-core,@wso2/font-wso2-vscode,@wso2/si-rpc-client,@wso2/ui-toolkit,@wso2/si-visualizer,streaming-integrator).vsce package.Security checks
Samples
N/A
Related PRs
Migrations (if applicable)
N/A
Test environment
Learning
undiciv8 requires Node.js 22+ built-inwebidl.util.markAsUncloneable. For Node 20 environments,undicimust be constrained to^6.24.0(resolves to 6.28.1) to avoid runtime TypeErrors while eliminating all 5 CVEs.svgicons2svgfontusessax-jswhich strictly checks the XML declaration against the detected stream encoding and rejectsiso-8859-1on UTF-8 streams.