Repository navigation
openstack_test: pre-count LB serial expected; hard-fail resolve mismatch - #47
Merged
openshift-merge-bot[bot] merged 1 commit intoOct 4, 2026
Conversation
In-loop expected++ under the OTE serial shell stays at 1 and false-fails resolvable!=expected after clean amphora runs (nightly edc5d1). Pre-count from the filtered list like serial coda. Also fail in rescue when resolvable!=expected so block/rescue cannot soft-recover a real mismatch. Co-authored-by: Cursor <cursoragent@cursor.com>
tusharjadhav3302
requested review from
chenwng,
dlaw4608,
ekuris-redhat,
eshulman2,
gryf,
imatza-rh,
mandre,
stephenfin and
winiciusallan
as code owners
October 2, 2026 07:08
Contributor
Author
|
Test Project PR : https://gitlab.cee.redhat.com/ci-framework/ci-framework-testproject/-/merge_requests/2756 |
Contributor
|
/lgtm |
|
/lgtm |
Contributor
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ekuris-redhat The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolvable!=expectedfailures on LB amphora serial OTE runs (seen on periodicedc5d1: shellexpected=1while rescue correctly counted 3/6 from the filtered list, with 0 test failures).expectedfromlist_of_tests_to_run.txtbefore the serial loop (same approach as serial coda); stop incrementing in-loop under/bin/sh.resolvable != expectedso block/rescue cannot soft-recover a real incomplete/inflated resolve after only marking UNSTABLE.Test plan
expected=1false fail)ote serial countsshowsexpectedequal to nonempty lines inlist_of_tests_to_run.txtMade with Cursor