Feature/more pro states - #1651
Merged
Merged
Conversation
ThomasSession
marked this pull request as ready for review
October 31, 2025 04:34
Comment on lines
+28
to
+30
| // show a toast and go back to pro settings home screen | ||
| Toast.makeText(LocalContext.current, R.string.errorGeneric, Toast.LENGTH_LONG).show() | ||
| onBack() |
Contributor
There was a problem hiding this comment.
Does this belong to a LaunchedEffect? I think for compose you can not assume the composition to be done only once. Because onBack is an async call under the hood, there's possible another recomposition and you'll end up with two toasts and two onBack calls.
Contributor
Author
There was a problem hiding this comment.
I think it's ok since we are calling onBack right after but I will still wrap it in a launchedEffect just in case
Comment on lines
+30
to
+35
| val context = LocalContext.current | ||
|
|
||
| LaunchedEffect(Unit) { | ||
| Toast.makeText(context, R.string.errorGeneric, Toast.LENGTH_LONG).show() | ||
| onBack() | ||
| } |
Contributor
There was a problem hiding this comment.
I think you should have LaunchedEffect testing the the state as input instead, and this should happen outside of the when
LaunchedEffect(state) {
if (state is State.Error) {
// Error stuff
}
}
SessionHero01
approved these changes
Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More logic and UI for the pro settings page and their various form factors
Added a loading and error state for the pro settings page screens
Properly linking up to the billing api to get prices and format them for display
Gave CTAs access to the subscription state to determine whichstring to display in some cases.