Conversation
…ed docs and tests
james-d-mitchell
changed the title
EdgesWithRange/Source, PathsWithRange/Source, and Positive/NegativePath for graph inverse semigroups
james-d-mitchell
left a comment
james-d-mitchell
left a comment
There was a problem hiding this comment.
Thanks @joe-dw, this is better, but still needs some improvements, and corrections. Please also try to have meaningful names for PRs in future, I edited this PR title to be more accurate, and possibly meaningful for future readers.
… behaviour of Paths/Edges with Source/Range to now return [] when given a non-vertex element
GAP 4.17 changes PreImagesSet: a generic method now checks that the argument is a subset of the range and returns the preimage of its intersection with the image. With that method, PreImagesSet no longer signals an error for elements without preimages, which the tests expect, and the error for elements outside the range changes. Install a method for semigroup homomorphisms by images that performs the range check with the package's own error message and otherwise delegates to PreImagesElm, so behaviour is the same with all supported GAP versions. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…roups with at most one vertex. (semigroups#1216)
5555d23 to
c46771e
Compare
|
I'm going to change how EdgesWithRange/Source works actually, because there's no reason it can't work with infinite but finitely generated semigroups. Only PathsWithRange/Source |
|
@james-d-mitchell I've just rewritten the docs to avoid a lot of repetition by grouping together functions with a similar description. Specifically this effects |
This branch has not been deployed
3 participants
This is a smaller version of PR #1204 containing only a few functions and the related documentation and tests.