Skip to content

Use filtered findings for check instead of the original #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rfelber merged 2 commits into from
Jul 2, 2021
Merged

Use filtered findings for check instead of the original #531

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5f2d91
Use filtered findings for check instead of the original
J12934 Jul 1, 2021
cc9dd26
Merge branch 'main' into fix/skipNotificationOnZeroFindings
rfelber Jul 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hooks/notification/hook.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export async function handle({ getFindings, scan }) {
channel.endPoint = mapToEndPoint(channel.endPoint);
const findingsToNotify = findings.filter(finding => matches(finding, channel.rules));

if (channel.skipNotificationOnZeroFindings === true && findings.length === 0) {
if (channel.skipNotificationOnZeroFindings === true && findingsToNotify.length === 0) {
continue;
}

Expand Down