Skip to content

Fix missing sslyze findings with sslyze 6.x #3351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Weltraumschaf merged 8 commits into from
Nov 6, 2025
Merged

Fix missing sslyze findings with sslyze 6.x #3351

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
174d875
Add a script to regen all sslyze jsons (somewhat) easily
J12934 Nov 5, 2025
181e4a7
Regenerate all sslyze testfiles with sslyze 6.2.0
J12934 Nov 5, 2025
7d3de5b
Fix parser for new sslyze formats
J12934 Nov 5, 2025
9330f6f
Update snapshots for new timestamps and updated IP addresses
J12934 Nov 5, 2025
cc76234
Also mark cert as untrusted if the chain in constructed invalidly
J12934 Nov 5, 2025
064387a
Do not create untrusted root findings if the root ca is passed as tru…
J12934 Nov 5, 2025
f7a5106
Add an example on how custom ca can be used with sslyze
J12934 Nov 5, 2025
050d5ce
License stuff
J12934 Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Also mark cert as untrusted if the chain in constructed invalidly 
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
  • Loading branch information
@J12934
J12934 committed Nov 5, 2025
commit cc762345fa8f82182d888ab5049e437035df6b8a
10 changes: 8 additions & 2 deletions scanners/sslyze/parser/parser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,10 +249,16 @@ function analyseCertificateDeployment(certificateDeployment) {
);
};

// Determine if the certificate is missing required extension
// Determine if the certificate has an untrusted root
// This can be indicated by multiple error patterns:
// 1. "Certificate is missing required extension"
// 2. "chain construction exceeds max depth"
const hasMissingRequiredExtension = hasErrorContaining(
"Certificate is missing required extension"
);
const hasChainDepthExceeded = hasErrorContaining(
"chain construction exceeds max depth"
);

return {
// To be trusted no openssl errors should have occurred and should match hostname
Expand All @@ -262,6 +268,6 @@ function analyseCertificateDeployment(certificateDeployment) {
),
selfSigned: isSelfSigned,
expired: hasErrorContaining("cert is not valid at validation time"),
untrustedRoot: hasMissingRequiredExtension && !isSelfSigned,
untrustedRoot: (hasMissingRequiredExtension || hasChainDepthExceeded) && !isSelfSigned,
};
}