Skip to content

Fix http-webhook chart #2878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
J12934 merged 4 commits into from
Feb 6, 2025
Merged

Fix http-webhook chart #2878

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1ab66c6
Fix containerPort in Deployment
muffl0n Jan 31, 2025
e31db21
Fix Ingress
muffl0n Jan 31, 2025
4d67351
Preserve empty lines
muffl0n Jan 31, 2025
1e854a3
Update helm unit snapshots
J12934 Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix Ingress 
serviceName and servicePort were removed and pathType is required in 1.22: https://kubernetes.io/docs/reference/using-api/deprecation-guide/#ingress-v122

Signed-off-by: Sven Schliesing <sven@schliesing.de>
  • Loading branch information
@muffl0n
muffl0n committed Jan 31, 2025
commit e31db21ca260da353ff888ffd37c093400ed6d71
13 changes: 6 additions & 7 deletions demo-targets/http-webhook/templates/ingress.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,7 @@
{{- if .Values.ingress.enabled -}}
{{- $fullName := include "http-webhook.fullname" . -}}
{{- $svcPort := .Values.service.port -}}
{{- if semverCompare ">=1.14-0" .Capabilities.KubeVersion.GitVersion -}}
apiVersion: networking.k8s.io/v1beta1
{{- else -}}
apiVersion: extensions/v1beta1
{{- end }}
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
name: {{ $fullName }}
Expand Down Expand Up @@ -37,9 +33,12 @@ spec:
paths:
{{- range .paths }}
- path: {{ . }}
pathType: Prefix
backend:
serviceName: {{ $fullName }}
servicePort: {{ $svcPort }}
service:
name: {{ $fullName }}
port:
name: http
{{- end }}
{{- end }}
{{- end }}