Skip to content

Improve Error Handling in DefectDojo Persistence Provider #2833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Weltraumschaf merged 25 commits into from
Feb 7, 2025
Merged

Improve Error Handling in DefectDojo Persistence Provider #2833

Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
563e16c
Use Lombok to Access Redonly Property
Weltraumschaf Dec 30, 2024
d3e00b4
Improves GRammar of Exception Messages
Weltraumschaf Dec 30, 2024
decfdd3
Move Property to top of Class to the Others
Weltraumschaf Dec 30, 2024
1600c8c
Make PersistenceProviderConfig Final to Prevent Extension
Weltraumschaf Dec 30, 2024
511c19b
Make Time Zone Final Becuase Never Changed
Weltraumschaf Dec 30, 2024
7deb89b
Move Cosntructor Before Methods As Expected
Weltraumschaf Dec 30, 2024
67b144b
Generate toString Method for Better Debugging
Weltraumschaf Dec 30, 2024
1dde6ac
Use Generated Nullcheck to simplify Code
Weltraumschaf Dec 30, 2024
294f303
Group Properties Together in Class
Weltraumschaf Dec 30, 2024
87ee122
Make Inline Comment A Real JavaDoc to be Visible in Intellisense
Weltraumschaf Dec 30, 2024
a0974d5
Docuemnt Unchecked Exception Condition
Weltraumschaf Dec 30, 2024
6e1eaf0
Improve and Test Wrong Argument Length Check
Weltraumschaf Dec 30, 2024
dfbbfad
Document Constructors of Exception
Weltraumschaf Jan 7, 2025
ee60cfa
Show Helpfull Errormessage When K8s Env Vars Not Set
Weltraumschaf Jan 7, 2025
cb28f63
Implement Help Message for Easier Usage of Final Binary
Weltraumschaf Jan 7, 2025
c09cc78
Verify Number of Passed In Arguments With Proper Error Message
Weltraumschaf Jan 7, 2025
c2e7e80
Tests For Help Flag
Weltraumschaf Jan 7, 2025
d7419e7
Log Warning When Running In Dev Mode To PRevent It In Production
Weltraumschaf Jan 7, 2025
1467ec2
Close File Reader By Using Try-With-Resource
Weltraumschaf Jan 7, 2025
fbb20fa
Add Shorthand Script to Execute Jar File
Weltraumschaf Jan 7, 2025
3730f86
Improve Error Message If Kubernetes Config Can't Be Read In Dev Mode
Weltraumschaf Jan 7, 2025
2365ba7
Handle Erros Parsing Kubernetes Config
Weltraumschaf Jan 7, 2025
6f4a291
Show Env Vars Also In Help Message
Weltraumschaf Jan 7, 2025
c31d600
Add Missing License Headers
Weltraumschaf Jan 7, 2025
0be20ca
Add Missing SPDX Headers
Weltraumschaf Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Docuemnt Unchecked Exception Condition 
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
  • Loading branch information
@Weltraumschaf
Weltraumschaf committed Feb 7, 2025
commit a0974d5a44d0dea5627af7e7e334190c124bd465
6 changes: 6 additions & 0 deletions ...ojo/hook/src/main/java/io/securecodebox/persistence/config/PersistenceProviderConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,13 +85,19 @@ public PersistenceProviderConfig(@NonNull final String[] args) {
}
}

/**
* Throws {@link DefectDojoPersistenceException} if {@link #isReadOnly()} is {@code true}
*/
public String getRawResultUploadUrl() {
if (isReadOnly()) {
throw new DefectDojoPersistenceException("Cannot access the RawResult Upload URL because the hook is executed in ReadOnly mode!");
}
return rawResultUploadUrl;
}

/**
* Throws {@link DefectDojoPersistenceException} if {@link #isReadOnly()} is {@code true}
*/
public String getFindingUploadUrl() {
if (isReadOnly()) {
throw new DefectDojoPersistenceException("Cannot access the Finding Upload URL because the hook is executed in ReadOnly mode!");
Expand Down