#2689 Handle 'Packages' attribute in Trivy parser - #2727
Merged
Ilyesbdlala merged 2 commits intoNov 19, 2024
Merged
Ilyesbdlala merged 2 commits into
Ilyesbdlala merged 2 commits into
Conversation
✅ Deploy Preview for docs-securecodebox ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
Author
|
Resolves #2689 |
BorisShek
marked this pull request as ready for review
October 22, 2024 12:38
BorisShek
marked this pull request as draft
October 23, 2024 13:02
BorisShek
force-pushed
the
scb-2689_handling_'packages'_attr_in_trivy_parser
branch
from
November 4, 2024 14:37
9aa7d71 to
7eb5ee1
Compare
BorisShek
marked this pull request as ready for review
November 4, 2024 14:48
Add 'Packages' to the expected attributes. However, this attribute will not be parsed due to its irrelevance for vulnerability findings. Signed-off-by: Boris Shek <boris.shek@iteratec.com>
BorisShek
force-pushed
the
scb-2689_handling_'packages'_attr_in_trivy_parser
branch
from
November 8, 2024 13:29
7eb5ee1 to
26f95dd
Compare
Member
|
Is there a reason why |
…he new version Update snapshot test files. Add a 'Packages' attribute to each result entry to simulate the new Trivy scanner conventions. Set its value as an empty list, as this attribute isnt parsed by the Trivy parser and is only included to match the updated format in Trivy 0.56.0 (aquasecurity/trivy#6765). Signed-off-by: Boris Shek <boris.shek@iteratec.com>
BorisShek
force-pushed
the
scb-2689_handling_'packages'_attr_in_trivy_parser
branch
from
November 12, 2024 15:21
26f95dd to
aebba11
Compare
|
Contributor
Author
Yes, i added a 'Packages' attribute to each result entry to simulate the new Trivy scanner conventions. I have set its value as an empty list, as this attribute isn't parsed by the Trivy parser and is only included to match the updated format in Trivy 0.56.0 (aquasecurity/trivy#6765). |
Ilyesbdlala
approved these changes
Nov 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add 'Packages' to the expected attributes. However, this attribute will not be parsed due to its irrelevance for vulnerability findings.
Description
Checklist