Skip to content

Increase Timeouts for Flaky Tests - #2118

Merged
J12934 merged 2 commits into
secureCodeBox:mainfrom
J12934:fix/reduce-flaky-tests
Dec 1, 2023
Merged

J12934 merged 2 commits into
secureCodeBox:mainfrom
J12934:fix/reduce-flaky-tests

Conversation

@J12934

@J12934 J12934 commented Dec 1, 2023

Copy link
Copy Markdown
Member

Description

These two failed often with timeouts. This increases them slightly to give them some more breathing room.

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure that all your commits are signed-off and that you are added to the Contributors file.
  • Make sure that all CI finish successfully.
  • Optional (but appreciated): Make sure that all commits are Verified.

… had just finished after the timeout was exceeded

Was possible to view in the post failure step that the scan finished afterwards.

Closes secureCodeBox#2073

Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
Should not increase the runtime in the usual cases as the timeout only affect cases in which they usually would have failed.

Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
@J12934 J12934 added testing Improvements or additions regarding the test setup skip-changelog Skipped from changelog generation labels Dec 1, 2023
@J12934
J12934 requested a review from Ilyesbdlala December 1, 2023 13:38
@J12934 J12934 self-assigned this Dec 1, 2023
@netlify

netlify Bot commented Dec 1, 2023 •

Copy link
Copy Markdown

✅ Deploy Preview for docs-securecodebox canceled.

Name Link
🔨 Latest commit ba40160
🔍 Latest deploy log https://app.netlify.com/sites/docs-securecodebox/deploys/6569e1efac01b40008600f50

@J12934
J12934 merged commit ba21a1c into secureCodeBox:main Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog Skipped from changelog generation testing Improvements or additions regarding the test setup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants