Skip to content

Remove deprecated userId attribute #1861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Weltraumschaf merged 8 commits into from
Aug 21, 2023
Merged

Remove deprecated userId attribute #1861

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
48d4fba
Remove deprecated userId
Aug 11, 2023
6162a9a
Adjust tests to work independently of Config class
Aug 11, 2023
a121809
Refactoring
Aug 11, 2023
2cd8c94
Bump defectdojo-client version from 1.0.0-SNAPSHOT to 1.0.0
Aug 11, 2023
e17a343
Merge branch 'main' into enhancement/remove-deprecated
Zero3141 Aug 11, 2023
ac02895
Merge branch 'main' into enhancement/remove-deprecated
Weltraumschaf Aug 11, 2023
3296396
Merge branch 'main' into enhancement/remove-deprecated
Zero3141 Aug 21, 2023
1c99d63
Merge branch 'main' into enhancement/remove-deprecated
Zero3141 Aug 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Adjust tests to work independently of Config class 
Signed-off-by: Heiko Kiesel <heiko.kiesel@iteratec.com>
  • Loading branch information
Heiko Kiesel
Heiko Kiesel committed Aug 11, 2023
commit 6162a9a9bfce94e33a442e3bb4b215dc7eb2b8ca
4 changes: 3 additions & 1 deletion ...java/io/securecodebox/persistence/mapping/DefectDojoFindingToSecureCodeBoxMapperTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,13 @@ class DefectDojoFindingToSecureCodeBoxMapperTest {
@Mock
FindingService findingService;

@Mock
Config config;

Finding exampleFinding;

@BeforeEach
public void setup(){
var config = new Config("http://example.defectdojo.com", "placeholder", "placeholder", 1000);
this.mapper = new DefectDojoFindingToSecureCodeBoxMapper(config, endpointService, findingService);

this.exampleFinding = Finding.builder()
Expand Down
5 changes: 4 additions & 1 deletion ...c/test/java/io/securecodebox/persistence/strategies/VersionedEngagementsStrategyTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,11 +52,14 @@ public class VersionedEngagementsStrategyTest {
@Mock
ImportScanService importScanService;

@Mock
Config config;

Scan scan;

@BeforeEach
public void setup() throws Exception {
versionedEngagementsStrategy.config = new Config("https://defectdojo.example.com", "<key>", "foobar", 1000);
versionedEngagementsStrategy.config = config;
versionedEngagementsStrategy.persistenceProviderConfig = new PersistenceProviderConfig(new String[]{"http://example.com","http://example.com"});

scan = new Scan();
Expand Down