Skip to content

maintenance: renamed Amass attributes.name to attributes.hostname - #1605

Merged
Ilyesbdlala merged 3 commits into
mainfrom
maintenance/amass-hostname
Mar 7, 2023
Merged

Ilyesbdlala merged 3 commits into
mainfrom
maintenance/amass-hostname

Conversation

@Ilyesbdlala

@Ilyesbdlala Ilyesbdlala commented Feb 20, 2023 •

Copy link
Copy Markdown
Member

This is done for consistency of finding format
relates to #853

Description

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure that all your commits are signed-off and that you are added to the Contributors file.
  • Make sure that all CI finish successfully.
  • Optional (but appreciated): Make sure that all commits are Verified.

@github-actions

github-actions Bot commented Feb 20, 2023 •

Copy link
Copy Markdown

MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
⚠️ DOCKERFILE hadolint 5 3 0.4s
⚠️ JAVASCRIPT eslint 2 1 0.82s
✅ SPELL misspell 7 0 0.05s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

@Ilyesbdlala Ilyesbdlala added the breaking Changes requiring a major release label Feb 21, 2023
@secureCodeBoxBot

Copy link
Copy Markdown
Contributor

This pull request includes breaking changes. Please make sure that you included the breaking changes and the steps required to upgrade in UPGRADING.md.
✨ Thank you for your contribution! ✨

Ilyesbdlala added a commit that referenced this pull request Feb 22, 2023
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
J12934
J12934 previously approved these changes Mar 7, 2023
This is done for consistency
relates to  #853

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking Changes requiring a major release maintenance

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants