Skip to content

fix(minio): includes minio authentication in operator makefile - #1577

Merged
Weltraumschaf merged 2 commits into
mainfrom
fix/minio-ci-auth
Feb 9, 2023
Merged

fix(minio): includes minio authentication in operator makefile#1577
Weltraumschaf merged 2 commits into
mainfrom
fix/minio-ci-auth

Conversation

@Ilyesbdlala

@Ilyesbdlala Ilyesbdlala commented Feb 2, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

minio bitnami chart requires including existing secret during helm upgrade.
This adds a step to fetch the credentials and set them during helm-deploy.

Signed-off-by: Ilyes Ben Dlala ilyes.bendlala@iteratec.com

Description

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure that all your commits are signed-off and that you are added to the Contributors file.
  • Make sure that all CI finish successfully.
  • Optional (but appreciated): Make sure that all commits are Verified.

@Ilyesbdlala
fix(minio): includes minio authentication in operator makefile
b98fd23 
minio bitnami chart require including exisiting secret during helm upgrade
This adds a step to fetch the credentials and set them during helm-deploy

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
@Ilyesbdlala Ilyesbdlala added the bug Bugs label Feb 2, 2023
@Ilyesbdlala Ilyesbdlala self-assigned this Feb 2, 2023
@github-actions

github-actions Bot commented Feb 2, 2023 •
edited
Loading

Copy link
Copy Markdown

MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ SPELL misspell 1 0 0.05s
✅ YAML prettier 1 0 0.8s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

@Ilyesbdlala
maintenance(operator/values.yaml): applied megalinter suggestions
c866bea 
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
@Weltraumschaf
Weltraumschaf merged commit 916b3a5 into main Feb 9, 2023
@Weltraumschaf
Weltraumschaf deleted the fix/minio-ci-auth branch February 9, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@the-simmon the-simmon the-simmon approved these changes

Assignees

@Ilyesbdlala Ilyesbdlala

Labels

bug Bugs

Projects

secureCodeBox
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Ilyesbdlala @the-simmon @Weltraumschaf