Added new DNS Scanner: Doggo - #1446
Merged
Merged
Conversation
MegaLinter status:
|
| Descriptor | Linter | Files | Fixed | Errors | Elapsed time |
|---|---|---|---|---|---|
| shfmt | 1 | 1 | 0.01s | ||
| hadolint | 2 | 1 | 0.12s | ||
| golangci-lint | 1 | 1 | 5.78s | ||
| eslint | 3 | 1 | 0.72s | ||
| ✅ JSON | eslint-plugin-jsonc | 3 | 0 | 1.05s | |
| ✅ SPELL | misspell | 15 | 0 | 0.06s | |
| prettier | 5 | 1 | 0.71s |
See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff
J12934
reviewed
Nov 18, 2022
rfelber
force-pushed
the
feature/doggo-dns-scanner
branch
from
December 11, 2022 06:53
3a7e179 to
db59127
Compare
rfelber
force-pushed
the
feature/doggo-dns-scanner
branch
from
February 26, 2023 08:20
db59127 to
b5082a3
Compare
rfelber
force-pushed
the
feature/doggo-dns-scanner
branch
from
March 7, 2023 15:23
b5082a3 to
1511091
Compare
Signed-off-by: Robert Seedorff <Robert.Seedorff@iteratec.com>
rfelber
force-pushed
the
feature/doggo-dns-scanner
branch
from
March 7, 2023 15:30
1511091 to
87983d9
Compare
added 3 commits
March 7, 2023 16:45
Signed-off-by: Robert Felber <Robert.Felber@iteratec.com>
Signed-off-by: Robert Felber <Robert.Felber@iteratec.com>
Signed-off-by: Robert Felber <Robert.Felber@iteratec.com>
rfelber
marked this pull request as ready for review
March 7, 2023 15:47
rfelber
enabled auto-merge (rebase)
March 7, 2023 15:48
Signed-off-by: Robert Felber <Robert.Seedorff@iteratec.com>
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
Without it, the sentence looks weird as it seems like the training dot in the entry is ending the sentence. Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
J12934
reviewed
Mar 17, 2023
J12934
left a comment
J12934
left a comment
Member
There was a problem hiding this comment.
Look good 👍
I've added some missing some example findings and refactored the parser a bit to be more in line with our other parsers.
I got one question in the comments below which would be nice to clear up before merging
based on review Feedback Signed-off-by: Robert Felber <Robert.Felber@iteratec.com>
J12934
approved these changes
Mar 27, 2023
auto-merge was automatically disabled
March 27, 2023 11:36
Rebase failed
Weltraumschaf
approved these changes
Mar 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a new DNS Scanner: Doggo
Checklist