Skip to content

Make userid optional for defectdojo - #1412

Merged
Weltraumschaf merged 8 commits into
mainfrom
optional_userid_defectdojo
Jan 25, 2023
Merged

Make userid optional for defectdojo#1412
Weltraumschaf merged 8 commits into
mainfrom
optional_userid_defectdojo

Conversation

@the-simmon

@the-simmon the-simmon commented Oct 19, 2022

Copy link
Copy Markdown
Contributor

This PR solves #783.
It depends on this PR from the defectdojo-client-java repo. So merge the other PR before this one.

@github-actions

github-actions Bot commented Oct 19, 2022 •
edited
Loading

Copy link
Copy Markdown

MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ GROOVY npm-groovy-lint 1 0 8.22s
⚠️ JAVA checkstyle 2 2 5.36s
✅ SPELL misspell 3 0 0.1s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

@the-simmon the-simmon self-assigned this Oct 25, 2022
@the-simmon
the-simmon marked this pull request as ready for review November 1, 2022 18:12
@rfelber rfelber added the defectdojo All issues regarding the DefectDojo Integration label Nov 16, 2022
@rfelber rfelber added this to the v4.0.0 milestone Nov 16, 2022
@rfelber rfelber linked an issue Nov 16, 2022 that may be closed by this pull request
DefectDojo Hook: Make explicitly specified user ID optional for new DefectDojo versions #783
Closed
@rfelber
rfelber force-pushed the optional_userid_defectdojo branch 2 times, most recently from 5a01295 to 69e2d2a Compare December 11, 2022 06:58
Weltraumschaf
Weltraumschaf reviewed Dec 13, 2022
View reviewed changes

@Weltraumschaf Weltraumschaf left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this test not needed anymore? In the subject under test you have two cases: One element as expected or empty list. Now you test neither.

@the-simmon
the-simmon force-pushed the optional_userid_defectdojo branch from 8efebde to 0fbad9a Compare December 16, 2022 12:22
@the-simmon

the-simmon commented Dec 16, 2022

Copy link
Copy Markdown
Contributor Author

Why is this test not needed anymore? In the subject under test you have two cases: One element as expected or empty list. Now you test neither.

You are right. Fixed the unit test to use the correct service now.

Weltraumschaf
Weltraumschaf previously approved these changes Dec 16, 2022
View reviewed changes
@Weltraumschaf
Weltraumschaf force-pushed the optional_userid_defectdojo branch 2 times, most recently from 5a6fe0c to 2487e6c Compare December 19, 2022 09:01
@the-simmon @Weltraumschaf
Use user profile endpoint to get defectdojo userid
1b0a326 
Signed-off-by: Simon Hülkenberg <simon.huelkenberg@iteratec.com>
@the-simmon @Weltraumschaf
Bump version of defectdojo-client-java
4b3df5b 
Signed-off-by: Simon Hülkenberg <simon.huelkenberg@iteratec.com>
@the-simmon @Weltraumschaf
Check if api returned empty list to avoid index out of bounds exception
9c60fd2 
Signed-off-by: Simon Hülkenberg <simon.huelkenberg@iteratec.com>
@the-simmon @Weltraumschaf
Add better logging to gradle config to see values of failed assertions
c138a07 
Signed-off-by: Simon Hülkenberg <simon.huelkenberg@iteratec.com>
@the-simmon @Weltraumschaf
Alter unit test to test empty response from user profile service inst…
38f6046 
…ead of user service

Signed-off-by: Simon Hülkenberg <simon.huelkenberg@iteratec.com>
@Weltraumschaf
Weltraumschaf force-pushed the optional_userid_defectdojo branch from 2487e6c to 38f6046 Compare December 19, 2022 09:02
Weltraumschaf
Weltraumschaf previously approved these changes Dec 19, 2022
View reviewed changes
@Weltraumschaf

Weltraumschaf commented Dec 19, 2022

Copy link
Copy Markdown
Member

@the-simmon Java test failes.

@the-simmon

the-simmon commented Jan 8, 2023

Copy link
Copy Markdown
Contributor Author

@the-simmon Java test failes.

yes because you have to merge the pr linked in the description first because i changed the defect-dojo-client version in build.gradle

@Weltraumschaf

Weltraumschaf commented Jan 10, 2023

Copy link
Copy Markdown
Member

secureCodeBox/defectdojo-client-java#25 merged

@Weltraumschaf

Weltraumschaf commented Jan 10, 2023

Copy link
Copy Markdown
Member

@the-simmon Do we need to release the client beforehand?

@the-simmon

the-simmon commented Jan 17, 2023

Copy link
Copy Markdown
Contributor Author

@the-simmon Do we need to release the client beforehand?

yes, good point

@rfelber

rfelber commented Jan 25, 2023

Copy link
Copy Markdown
Member

@the-simmon you can now use the version 0.0.40-SNAPSHOT which contains the latest changes in the underlying defectdojo-client lib.

rfelber
rfelber previously requested changes Jan 25, 2023
View reviewed changes
Comment thread hooks/persistence-defectdojo/hook/build.gradle Outdated
@Weltraumschaf @rfelber
Update hooks/persistence-defectdojo/hook/build.gradle
5eff449 
Co-authored-by: Robert Felber <Robert.Seedorff@iteratec.com>
Signed-off-by: Sven Strittmatter <ich@weltraumschaf.de>
@Weltraumschaf

Weltraumschaf commented Jan 25, 2023

Copy link
Copy Markdown
Member

For Semver's sake we should got to version 1.0.0-SNAPSHOT.

@Weltraumschaf
Weltraumschaf merged commit be253f5 into main Jan 25, 2023
@Weltraumschaf
Weltraumschaf deleted the optional_userid_defectdojo branch January 25, 2023 19:18
@rfelber rfelber added the persistence Implement or update a persistence store label Mar 7, 2023
@rfelber rfelber added the hook Implement or update a hook label Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Weltraumschaf Weltraumschaf Weltraumschaf approved these changes
@rfelber rfelber rfelber left review comments

Assignees

@the-simmon the-simmon

Labels

defectdojo All issues regarding the DefectDojo Integration hook Implement or update a hook persistence Implement or update a persistence store

Projects

secureCodeBox
Archived in project

Milestone

v4.0.0

Development

Successfully merging this pull request may close these issues.

DefectDojo Hook: Make explicitly specified user ID optional for new DefectDojo versions

3 participants

@the-simmon @Weltraumschaf @rfelber