Feature: CAN XL Support by RB-FriedrichWiemer · Pull Request #5152 · secdev/scapy

RB-FriedrichWiemer · 2026-09-07T12:57:53Z

Description

This is my first pull request to scapy.
It adds CAN XL support to the existing CAN layer, making use of the CAN XL implementation available on Linux' SocketCAN.

polybassa · 2026-09-08T12:37:24Z

Thanks for this PR. Please resolve the conflicts with the master.

codecov · 2026-09-08T13:01:33Z

Codecov Report

❌ Patch coverage is 47.82609% with 72 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.46%. Comparing base (c935a75) to head (87ae595).

Files with missing lines	Patch %	Lines
scapy/layers/can.py	42.57%	58 Missing ⚠️
scapy/contrib/cansocket_native.py	60.60%	13 Missing ⚠️
scapy/contrib/cansocket_python_can.py	75.00%	1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (c935a75) and HEAD (87ae595). Click for more details.

HEAD has 10 uploads less than BASE

Flag BASE (c935a75) HEAD (87ae595)

12 2

Additional details and impacted files

@@             Coverage Diff             @@
##           master    #5152       +/-   ##
===========================================
- Coverage   80.96%   47.46%   -33.50%     
===========================================
  Files         390      372       -18     
  Lines       96994    96755      -239     
===========================================
- Hits        78530    45926    -32604     
- Misses      18464    50829    +32365

Files with missing lines	Coverage Δ
scapy/contrib/cansocket_python_can.py	`79.79% <75.00%> (-4.59%)`	⬇️
scapy/contrib/cansocket_native.py	`67.88% <60.60%> (-10.69%)`	⬇️
scapy/layers/can.py	`38.12% <42.57%> (-54.98%)`	⬇️

... and 340 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

pfasante · 2026-09-22T10:01:17Z

the byte-swap for wireshark pcaps I still need to check

polybassa

Looks good. Let's check what wireshark does, then we can merge

polybassa · 2026-09-25T19:10:36Z

Please fix the failing job.

polybassa · 2026-09-28T19:58:33Z

sorry, there is still the AI-Trailer job failing. You may need to to a rebase.

Introduce the CANXL class in scapy.layers.can, following the Linux struct canxl_frame wire format and inheriting from the CAN class. Provides additional ISO 11898-1:2024 property accessors and show(style='11898-1') for ISO field-name rendering. AI-Assisted: yes (Claude Opus and Sonnet)

AI-Assisted: yes (Claude Opus and Sonnet)

Tests pass on Linux. On Windows, tests appear to timeout -- needs further investigation. AI-Assisted: yes (Claude Opus and Sonnet)

Covers quick start, field naming (Linux vs ISO), byte-order handling, NativeCANSocket usage, can-utils interop, and known limitations. AI-Assisted: yes (Claude Opus and Sonnet)

AI-Assisted: yes (Claude Opus and Sonnet)

AI-Assisted: no

Declare the CAN XL header as little endian via BitField's tot_size / end_tot_size, LEShortField and XLEIntField, instead of swapping the prio, length and af regions by hand. Removes CANXL.inv_endianness() and the swap in pre_dissect() and post_build(). AI-Assisted: yes (Claude Opus and Sonnet)

post_dissect duplicated CAN.post_dissect, and the default guess_payload_class already returns conf.raw_layer when no payload class is bound. AI-Assisted: yes (Claude Opus and Sonnet)

Keep Packet.show()'s signature unchanged and expose the ISO 11898-1 rendering as its own method. AI-Assisted: yes (Claude Opus and Sonnet)

Use Packet.sprintf() for the fields it can resolve instead of formatting each one against the color theme by hand. Format, FTYPE, SEC and DLC are properties rather than fields, so they stay resolved in Python. AI-Assisted: yes (Claude Opus and Sonnet)

Both recv_raw() and send() open-coded the same four-byte swap that CAN.inv_endianness() already performs. Also drops _is_canxl(), a single-use wrapper around CANXL.is_canxl_frame(). AI-Assisted: yes (Claude Opus and Sonnet)

AI-Assisted: yes (Gemini 3.8 Flash)

gpotter2 · 2026-09-29T21:52:28Z

@polybassa

sorry, there is still the AI-Trailer job failing. You may need to to a rebase.

finally managed to fix that need for rebasing... will merge it ASAP. sorry about that 78c41b5