pullrequests Search Results · author:brianrourkeboll
Filter by
115 results
Workaround for https://github.com/testcontainers/Docker.DotNet/issues/129.
- Enable RespectNullableAnnotationsDefault and RespectRequiredConstructorParametersDefault globally in this repo. (The
...
brianrourkeboll
Description
Follows https://github.com/dotnet/fsharp/pull/18927.
- Add additional, off-by-default informational shadowing warnings for record spreads. These are intended more as
optional refactoring ...
AI-reviewed
AI-Tooling-Check-Scanned-Clean
Description
Fixes https://github.com/dotnet/fsharp/issues/19367.
- Use char overload of IndexOf to ensure culture-independent behavior.
Checklist
- [x] Test cases added.
- [x] Release notes entry ...
Add emitted IL tests for more kinds of possibly-overflowing mappings.
I used a loop body of id id () as a somewhat more minimal repro than the one in
https://github.com/dotnet/fsharp/issues/19156.
Description
Fixes #19074.
- Support explicit struct optional args: ?x=….
Checklist
- [x] Test cases added.
- [ ] Release notes entry updated.
Related to https://github.com/fscheck/FsCheck/issues/696.
- Add a replay hint to the failure message when a test fails after more than 1 test. Enables easy copy-pasting for use
like https://github.com/fscheck/FsCheck/issues/696#issuecomment-2610886817. ...
Fixes https://github.com/fscheck/FsCheck/issues/718.
- Add FSharp.Core version override for test proj to enable using the task computation expression in tests.
- FsCheck.NUnit: only skip setting full ...
Description
Fixes https://github.com/dotnet/fsharp/issues/18993. Fixes https://github.com/dotnet/fsharp/issues/6069.
- Emit error FS0954: This type definition involves an immediate cyclic reference ...
Description
Adds language support for record-to-record type and expression spreads.
type R1 = { A : int; B : int }
type R2 = { C : int; D : int }
type R3 = { ...R1; ...R2; E : int } // { ...
Area-Experimental-Features
Needs-Verify next release
This PR adds prior art interop sections to the RFC template. While I don t think we should always feel constrained by
prior art or interop, I think it wouldn t hurt to have a reminder to consider them ...