Repository navigation
ci: exclude pytest 9.1.0 (params-fixture override regression) - #1329
Merged
Merged
Conversation
pytest 9.1.0 regressed overriding a params-fixture via `@pytest.mark.parametrize(..., indirect=True)`, raising "duplicate parametrization" at collection. With filterwarnings=error this hard-fails the editable-fixture tests. Fixed upstream in 9.1.1. Refs: pytest-dev/pytest#13974 Assisted-by: ClaudeCode:claude-opus-4.8
henryiii
added a commit
to pypa/pyproject-metadata
that referenced
this pull request
Jun 16, 2026
Updates the scikit-build-core downstream test pin to its current main HEAD (70fc620), which excludes the broken pytest 9.1.0 (scikit-build/scikit-build-core#1329). The previous pin (8621243) pulled pytest 9.1.0, whose params-fixture override regression broke scikit-build-core's test collection, reddening the downstream job on unrelated PRs. Assisted-by: ClaudeCode:claude-opus-4.8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Problem
pytest 9.1.0 shipped a regression (pytest-dev/pytest#13974, fixed upstream in #13976, landing in 9.1.1) where overriding a
params=-fixture via@pytest.mark.parametrize(..., indirect=True)raisesduplicate parametrizationat collection time.Because our config sets
filterwarnings = ["error"]and these surface as collection errors, the suite hard-fails on the three tests that override theeditablefixture (defined withparams=[None, "redirect", "inplace"]intests/conftest.py):test_editable.py::test_cython_pxdtest_editable_generated.py::test_generated_filestest_pyproject_pep660.py::test_pep660_wheelFix
Pin
pytest >=7.2,!=9.1.0in thetest-coredependency group. The exclusion is narrow: 9.1.1+ (with the upstream fix) is allowed once released. No test code changes needed.Verified collection is clean (622 tests, no errors) with the pin applied.
🤖 Generated with Claude Code