Skip to content

Avoid leaving an empty buffer on complete consume - #25

Closed
Nibbler999 wants to merge 2 commits into
rvagg:masterfrom
Nibbler999:full-consume
Closed

Nibbler999 wants to merge 2 commits into
rvagg:masterfrom
Nibbler999:full-consume

Conversation

@Nibbler999

Copy link
Copy Markdown

No description provided.

@mcollina

Copy link
Copy Markdown
Collaborator

CI is failing on node v5: https://travis-ci.org/rvagg/bl/jobs/108262808.

Also, can you add a unit test?

@Nibbler999

Copy link
Copy Markdown
Author

nodejs/node#4951

You want a new test instead of extending the existing one?

@mcollina

Copy link
Copy Markdown
Collaborator

Yes please, add a new test! Thanks for the reference to core.
Il giorno mer 10 feb 2016 alle 12:38 Tom Atkinson notifications@github.com
ha scritto:

nodejs/node#4951 nodejs/node#4951

You want a new test instead of extending the existing one?

—
Reply to this email directly or view it on GitHub
#25 (comment).

@Nibbler999

Copy link
Copy Markdown
Author

Updated with separate test.

@mcollina

Copy link
Copy Markdown
Collaborator

I would release this as patch as well cc @jcrugzz @rvagg.

@rvagg

rvagg commented Feb 11, 2016

Copy link
Copy Markdown
Owner

lgtm, lets get #26 / #27 sorted first then we can release with that as well

@rvagg

rvagg commented Feb 11, 2016

Copy link
Copy Markdown
Owner

just pushed out v1.0.3 with this

@rvagg rvagg closed this Feb 11, 2016
@mcollina

Copy link
Copy Markdown
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants