Repository navigation
Conversation
- Dependabot walked the image 20 -> 25 -> 26 onto a non-LTS current line while CI stayed on 20 and engines still claimed >=18; pin all of them to 24 LTS and add .nvmrc so local dev matches - Node 24 avoids the Web Storage default introduced in 25, which shadows jsdom's localStorage and breaks any test touching it - Hold back Docker node majors so the next LTS move is deliberate rather than drifting back apart
rusahu
changed the title
Owner
Author
|
Superseded by #122 — same change, branch renamed (this one said |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node was pinned in four places with three different answers, and nobody chose any of them.
Dockerfile×3.github/workflows/ci.yml×2engines>=18.0.0>=24.0.0.nvmrc→ 24How it drifted
Dependabot manages the Dockerfile's
FROMbut cannot seesetup-nodein workflow YAML. So the shipped image marched 20 → 25 → 26 while CI stayed on 20 — meaning every check was validating a runtime we never deploy.Why 24 and not 26
Web Storage was unflagged in Node 25 (nodejs/node#57666). From 25 onward, Node installs its own
localStorageglobal that shadows jsdom's and is unusable without--localstorage-file— it throws on 25 and isundefinedon 26 (nodejs/node#61333). Any test touchinglocalStoragedies; a first attempt at this PR on Node 26 failed exactly that way inSetlistPlayView.test.tsx, and it is a known vitest issue (vitest-dev/vitest#8757).Node 26 would have meant carrying
execArgv: ['--no-webstorage']in the vitest config indefinitely. Node 24 has no such problem, needs no workaround, and is LTS (Krypton). It also satisfies every dependency floor currently blocked: better-sqlite3 13 (>=22), jsdom 30 (^24.15.0), jest-dom 7 (>=22).Docker node majors are now held back
Without this the change does not stick — Dependabot would bump straight back to 26 next week and re-split CI from production. Minor and patch updates still come through; the next LTS move becomes deliberate, updating all four places together.
Unblocks
#116 (better-sqlite3 13), #117 (jsdom 30) and #118 (jest-dom 7) all require Node ≥22 and were failing only because CI ran 20.
Note
enginesnow says>=24.0.0. Anyone developing locally on Node 22 will need to switch —.nvmrcis there for that.