Skip to content

Add type checking with ty #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jason-rl wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Add type checking with ty #702

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7d2938a
Add type checking with ty
jason-rl Dec 6, 2025
f67e097
redundant-cast
jason-rl Dec 6, 2025
987b083
invalid-explicit-override
jason-rl Dec 6, 2025
6dc7707
no-matching-overload
jason-rl Dec 6, 2025
46a8a72
remove unnecessary type ignore
jason-rl Dec 8, 2025
a3fef99
remove pyright ignore
jason-rl Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove unnecessary type ignore
  • Loading branch information
@jason-rl
jason-rl committed Dec 8, 2025
commit 46a8a7253ebe9a74522d62ab6beabfe575c2b626
6 changes: 3 additions & 3 deletions src/runloop_api_client/_base_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ def iter_pages(self: SyncPageT) -> Iterator[SyncPageT]:
while True:
yield page
if page.has_next_page():
page = page.get_next_page() # type: ignore
page = page.get_next_page()
else:
return

Expand Down Expand Up @@ -483,7 +483,7 @@ def _build_request(
if json_data is None:
json_data = cast(Body, options.extra_json)
elif is_mapping(json_data):
json_data = _merge_mappings(json_data, options.extra_json) # type: ignore
json_data = _merge_mappings(json_data, options.extra_json)
else:
raise RuntimeError(f"Unexpected JSON data type, {type(json_data)}, cannot merge with `extra_body`")

Expand All @@ -510,7 +510,7 @@ def _build_request(
raise TypeError(
f"Expected query input to be a dictionary for multipart requests but got {type(json_data)} instead."
)
kwargs["data"] = self._serialize_multipartform(json_data) # type: ignore
kwargs["data"] = self._serialize_multipartform(json_data)

# httpx determines whether or not to send a "multipart/form-data"
# request based on the truthiness of the "files" argument.
Expand Down