Skip to content

Add Gem.operating_system_defaults to allow packagers to override defaults. - #2116

Merged
bundlerbot merged 1 commit into
ruby:masterfrom
voxik:operating_system_defaults
Dec 19, 2017
Merged

bundlerbot merged 1 commit into
ruby:masterfrom
voxik:operating_system_defaults

Conversation

@voxik

@voxik voxik commented Dec 19, 2017

Copy link
Copy Markdown
Contributor

Description:

This change allows Ruby packagers to override defaults and lazily query
them.

This is very much the same change as #1644 to treat the
operating_system defaults the same way as platform defaults.

Tasks:

  • Describe the problem / feature
  • Write tests
  • Write code to solve the problem
  • Get code review from coworkers / friends

I will abide by the code of conduct.

…ults.

This change allows Ruby packagers to override defaults and lazily query
them.

This is very much the same change as ruby#1644 to treat the
operating_system defaults the same way as platform defaults.
@colby-swandale

Copy link
Copy Markdown
Member

Thanks! @bundlerbot r+

@bundlerbot

Copy link
Copy Markdown
Contributor

📌 Commit 60eb961 has been approved by colby-swandale

@bundlerbot

Copy link
Copy Markdown
Contributor

⌛ Testing commit 60eb961 with merge 9a18b82...

bundlerbot added a commit that referenced this pull request Dec 19, 2017
Add Gem.operating_system_defaults to allow packagers to override defaults.

# Description:

This change allows Ruby packagers to override defaults and lazily query
them.

This is very much the same change as #1644 to treat the
operating_system defaults the same way as platform defaults.

# Tasks:

- [x] Describe the problem / feature
- [x] Write tests
- [x] Write code to solve the problem
- [ ] Get code review from coworkers / friends

I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).
@bundlerbot

Copy link
Copy Markdown
Contributor

☀️ Test successful - status-travis
Approved by: colby-swandale
Pushing 9a18b82 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants