Autoload the deprecated IgnoredMethods and IgnoredPattern aliases - #15588
Merged
Merged
Conversation
… aliases Since cops are loaded lazily, nothing requires allowed_methods.rb or allowed_pattern.rb at load time, so the deprecated aliases defined there are unreachable after a bare `require "rubocop"`. They previously resolved only as a side effect of eager cop loading; mixin.rb has never registered them. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RuboCop::Cop::IgnoredMethodsandRuboCop::Cop::IgnoredPattern— the deprecated aliases added in #10829 "in order to not break extensions" — are unreachable after a barerequire "rubocop"since cops became lazily loaded in #14983:The same command with
-v 1.88.2printsRuboCop::Cop::AllowedMethods. The aliases are defined insideallowed_methods.rb/allowed_pattern.rb, so they only ever resolved as a side effect of eager cop loading;mixin.rbhas never registered them.The spec lives in
lazy_loading_spec.rband asserts through a freshruby -Ilibprocess, since the constants resolve trivially once the suite has loaded cops.Happy to make this a removal instead if you would rather retire the aliases.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.