Downgrade 'Failed to parse type hash' log from WARN to DEBUG - #591
Merged
fujitatomoya merged 1 commit intoJul 16, 2026
Merged
Conversation
The warning 'Failed to parse type hash for topic' is expected when a topic uses a type that predates type hash support or comes from a non-ROS 2 source. Emitting it at WARN level floods the console and confuses users who are not using type hashes. Downgrading to DEBUG keeps the information available for diagnostics without alarming users. Fixes ros2#567 Signed-off-by: Functionhx <2994114386@qq.com>
|
Tick the box to add this pull request to the merge queue (same as
|
fujitatomoya
approved these changes
Jul 15, 2026
Contributor
|
Pulls: #591
|
Contributor
|
@Mergifyio backport lyrical kilted jazzy |
✅ Backports have been createdDetails
|
ahcorde
pushed a commit
that referenced
this pull request
Jul 27, 2026
…595) The warning 'Failed to parse type hash for topic' is expected when a topic uses a type that predates type hash support or comes from a non-ROS 2 source. Emitting it at WARN level floods the console and confuses users who are not using type hashes. Downgrading to DEBUG keeps the information available for diagnostics without alarming users. Fixes #567 (cherry picked from commit e0886a3) Signed-off-by: Functionhx <2994114386@qq.com> Co-authored-by: FAN YUCHEN <2994114386@qq.com>
ahcorde
pushed a commit
that referenced
this pull request
Jul 27, 2026
…596) The warning 'Failed to parse type hash for topic' is expected when a topic uses a type that predates type hash support or comes from a non-ROS 2 source. Emitting it at WARN level floods the console and confuses users who are not using type hashes. Downgrading to DEBUG keeps the information available for diagnostics without alarming users. Fixes #567 (cherry picked from commit e0886a3) Signed-off-by: Functionhx <2994114386@qq.com> Co-authored-by: FAN YUCHEN <2994114386@qq.com>
ahcorde
pushed a commit
that referenced
this pull request
Jul 27, 2026
…597) The warning 'Failed to parse type hash for topic' is expected when a topic uses a type that predates type hash support or comes from a non-ROS 2 source. Emitting it at WARN level floods the console and confuses users who are not using type hashes. Downgrading to DEBUG keeps the information available for diagnostics without alarming users. Fixes #567 (cherry picked from commit e0886a3) Signed-off-by: Functionhx <2994114386@qq.com> Co-authored-by: FAN YUCHEN <2994114386@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Downgrade "Failed to parse type hash for topic" from WARN to DEBUG.
The type hash parsing failure is a non-fatal compatibility case:
after logging and resetting the error, the endpoint is still added
to the graph cache. The implementation already treats this as non-fatal:
it resets the error, uses a zero-initialized type hash, and continues
graph discovery. Legacy ROS 2 and non-ROS DDS endpoints may legitimately
not provide ROS type-hash data. On heterogeneous ROS 2 systems with
endpoints that predate type hash support, this WARN fires per-endpoint
and floods the console with noise the user cannot act on.
This also aligns rmw_cyclonedds with ros2/rmw_connextdds#149,
which downgraded the equivalent diagnostic from WARN to DEBUG.
Fixes #567.